Closed
Bug 479904
Opened 15 years ago
Closed 15 years ago
There is a white background around the Star panel
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: whimboo, Assigned: dev-null)
References
Details
(Keywords: regression, verified1.9.1, Whiteboard: [fixed on 1.9.1 by bug 469631])
Attachments
(2 files)
36.55 KB,
image/jpeg
|
Details | |
680 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090223 Minefield/3.2a1pre Opening the star panel shows an ugly white background around its boundaries. See the attachment. Steps: * Click twice on the star if the web page isn't bookmarked yet * Press Cmd+D to bookmark the page
Comment 1•15 years ago
|
||
per Enn: maybe regression from bug 475343?
I would have sworn this was the same as bug 478784, except that seems to have landed before the 23rd.
Is this still a bug on trunk? If so, it should block.
Blocks: 475343
Oh, it definitely is. Yuck. It's not a general transparent widgets bug, since the EV dropdown does work.
Backing out the Mac part of bug 475343 didn't fix it, so it's something else. Better find a regression range.
No longer blocks: 475343
Reporter | ||
Comment 6•15 years ago
|
||
Regressed between the builds: http://hg.mozilla.org/mozilla-central/rev/784122b49e33 http://hg.mozilla.org/mozilla-central/rev/4de266682b1f Changesets: http://tinyurl.com/cxp9gu
Keywords: regressionwindow-wanted
Updated•15 years ago
|
Flags: blocking-firefox3.2?
Assignee | ||
Comment 8•15 years ago
|
||
Bug 469631 has been specified panel's background-color, but Page Bookmarked/Edit This Bookmark panel should be transparent.
Attachment #364900 -
Flags: review?(dao)
Updated•15 years ago
|
Component: Places → Theme
QA Contact: places → theme
Updated•15 years ago
|
Attachment #364900 -
Flags: review?(dao) → review+
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → dev-null
Keywords: checkin-needed
Comment 9•15 years ago
|
||
pushed: http://hg.mozilla.org/mozilla-central/rev/e192f700fef4 Thanks for the patch!
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: blocking-firefox3.2?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Reporter | ||
Comment 11•15 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090304 Minefield/3.2a1pre ID:20090304021932
Status: RESOLVED → VERIFIED
Comment 12•15 years ago
|
||
Fixed on 1.9.1 by the landing of the adjusted patch in bug 469631.
Keywords: fixed1.9.1
Reporter | ||
Comment 13•15 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090416 Shiretoko/3.5b4pre ID:20090416030924
You need to log in
before you can comment on or make changes to this bug.
Description
•