480046 - Windows builder logs hard to read because they re-print all warnings at the end

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox&errorparser=unix&logfile=1235506868.1235518985.394.gz&buildtime=1235506868&buildname=WINNT%205.2%20mozilla-central%20build&fulltext=1 is really hard to read, as a log, because the build log contains:

 (1) the build log, which ends with an error (command timed out: 5400 seconds without output)

followed immediately (with no useful delimiters) by:

 (2) a copy of every line in (1) with "warning" in it.

This duplication of all the warnings makes the log very hard to read, since the error is very far from the end.

(Also, was this machine so starved that linking libxul hung for more than an hour and a half?)

Comment 1

[[e-mail] (:bhearsum)]

Yeah, Buildbot generates a 'warnings' log, which is great on its Waterfall but pretty silly for Tinderbox. There's a few ways to get around this, I'll have a look this week.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: s/ShellCommand/Compile/g

I don't think there's any win to keeping the Compile step - I've never heard of anyone looking at the 'warnings' log on the waterfall. Other than that, Compile doesn't do anything different than ShellCommand.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 364153 [details] [diff] [review]
s/ShellCommand/Compile/g

changeset:   203:8a153398aa56

Comment 4

[[e-mail] (:bhearsum)]

master reconfig'ed for this.

Comment 5

[Serge Gautherie (:sgautherie)]

Ftr,
http://hg.mozilla.org/build/buildbotcustom/rev/c2484f6c012e
Minor fixes to clean up buildbot display after bug 480046

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> Ftr,
> http://hg.mozilla.org/build/buildbotcustom/rev/c2484f6c012e
> Minor fixes to clean up buildbot display after bug 480046

And the second part of this check-in is actually bug 479660 content :->

Comment 7

[[e-mail] (:bhearsum)]

That's weird. Thanks for catching that Serge...