480111 - [TSF]mCompositionStart and mCompositionLength is not updated on WinXP

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

On WinXP, mCompositionStart and mCompositionLength will not be updated because |OnUpdateComposition| is called with pRangeNew == null. We should also updete them as well as composition string. The latter was fixed by bug 478030. This bug will cover the former.
This caused many strange behavior when we used Japanese IME, Natural Input.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch v1.1

Sorry, the previous patch caused some test failures.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Jim is busy in these days.

I'll review the patch ASAP.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 364095 [details] [diff] [review]
patch v1.1

Ok. Plaese review the patch.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 364095 [details] [diff] [review]
patch v1.1

> nsTextStore::UpdateCompositionExtent(ITfRange* pRangeNew)

This method is not an interface method of TSF, so, you should use our naming rule for pRangeNew, so, it should be aRangeNew.

Otherwise, looks ok. Thank you for your work!

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: patch v1.11 - argument name changed [Checkin: Comment 6]

Oops, forgot to update a patch.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 365649 [details] [diff] [review]
patch v1.11 - argument name changed
[Checkin: Comment 6]


http://hg.mozilla.org/mozilla-central/rev/537eccc6c218