Closed Bug 480967 Opened 12 years ago Closed 12 years ago
Don't leak MSYS paths into makefiles
We currently use MSYS make to build on Windows. For pymake, and for the future possibility of using mingw-make, we shouldn't leak MSYS paths into makefiles: use forward-slash win32 paths such as c:/path/foo. MSYS make understands these paths just fine. The attached patch covers most autoconf.mk paths, but does *not* cover @srcdir@ and @topsrcdir@ substitutions when these substitutions are absolute paths. That will come later. An earlier version of this patch passed tryserver. The only subsequent change was the s|\\|/| in mddepend.pl which was needed because mddepend apparently doesn't like mixed forward and backslashes in dependencies.
Attachment #364919 - Flags: review?(ted.mielczarek)
Comment on attachment 364919 [details] [diff] [review] Don't leak MSYS paths into makefiles, rev. 1 Do you plan to file a followup to fix acoutputfast, or are you going to do it here?
Attachment #364919 - Flags: review?(ted.mielczarek) → review+
I'll do it separately.
Benjamin, can you use "uname -s" instead of "uname -o"? /usr/bin/uname on Solaris doesn't have "-o" option.
Attachment #366519 - Attachment description: patch → use "uname -s" instead
Attachment #366519 - Flags: review?(benjamin) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Fix for Solaris bustage http://hg.mozilla.org/mozilla-central/rev/ae7ce7e47f5a
What about 1.9.1?
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.