Port |Bug 480967 - Don't leak MSYS paths into makefiles| to comm-central

VERIFIED FIXED in Thunderbird 3.1b2

Status

defect
--
trivial
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: sgautherie, Assigned: Callek)

Tracking

Trunk
Thunderbird 3.1b2
x86
Windows 2000
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

10 years ago
No description provided.
Flags: in-testsuite-
Assignee

Comment 1

9 years ago
Posted patch v1.0 -- This should do it (obsolete) — Splinter Review
holding off review until I get a chance to have this (patch stack) run through try.

This patch itself depends on Bug 543382, and Bug 550657; just based on the ordering.
Assignee

Comment 2

9 years ago
Comment on attachment 432482 [details] [diff] [review]
v1.0 -- This should do it

>-PWD := $(CURDIR)
>+ifdef MOZILLA_1_9_2_BRANCH
>+_VPATH_SRCS = $(if $(filter /%,$<),$<,$(CURDIR)/$<)
>+else
> _VPATH_SRCS = $(abspath $<)
>+fi
> else
> _VPATH_SRCS = $<
> endif

I was obviously tired when writing this... s/+fi/+endif/
Assignee

Comment 3

9 years ago
Posted patch v1.1 (obsolete) — Splinter Review
builds fine locally (with my full patch stack), will run through try once I get that setup.
Attachment #432482 - Attachment is obsolete: true
Attachment #433009 - Flags: review?(kairo)
Assignee

Comment 4

9 years ago
We actually shouldn't revert the $(abspath change I did from the other bug; it doesn't have a 1.9.2 landing, but this machinery should all work anyway. (Try will tell)
Attachment #433010 - Flags: review?(kairo)

Comment 5

9 years ago
Comment on attachment 433009 [details] [diff] [review]
v1.1

This v1.1 is obsolete, I guess?

Updated

9 years ago
Attachment #433010 - Flags: review?(kairo) → review+
Assignee

Comment 6

9 years ago
Comment on attachment 433009 [details] [diff] [review]
v1.1

yes, obsolete.
Attachment #433009 - Attachment is obsolete: true
Attachment #433009 - Flags: review?(kairo)
Assignee

Comment 7

9 years ago
(In reply to comment #4)
> Created an attachment (id=433010) [details]
> v1.2
> 
> We actually shouldn't revert the $(abspath change I did from the other bug; it
> doesn't have a 1.9.2 landing, but this machinery should all work anyway. (Try
> will tell)

To be clear on this, I'm just waiting for a few patches to be sr'ed by standard8 so I have to unbitrot this or those patches by pushing early.
Assignee

Comment 8

9 years ago
Pushed as: http://hg.mozilla.org/comm-central/rev/ad08c4e0a3c6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee

Comment 9

9 years ago
backed out
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 10

9 years ago
Repushed-as http://hg.mozilla.org/comm-central/rev/f903ba8ca1b4 (hope this sticks)
Reporter

Updated

9 years ago
Attachment #433010 - Attachment description: v1.2 → v1.2 [Checkin: Comment 10]
Reporter

Comment 11

9 years ago
V.Fixed, per tinderboxes.

I updated http://dev.seamonkey.at/?d=x&i=mozilla&m=c too ;-)
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
Reporter

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.