Closed
Bug 545313
Opened 14 years ago
Closed 14 years ago
Port |Bug 480967 - Don't leak MSYS paths into makefiles| to comm-central
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird 3.1b2
People
(Reporter: sgautherie, Assigned: Callek)
References
Details
Attachments
(1 file, 2 obsolete files)
6.11 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•14 years ago
|
||
holding off review until I get a chance to have this (patch stack) run through try. This patch itself depends on Bug 543382, and Bug 550657; just based on the ordering.
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 432482 [details] [diff] [review] v1.0 -- This should do it >-PWD := $(CURDIR) >+ifdef MOZILLA_1_9_2_BRANCH >+_VPATH_SRCS = $(if $(filter /%,$<),$<,$(CURDIR)/$<) >+else > _VPATH_SRCS = $(abspath $<) >+fi > else > _VPATH_SRCS = $< > endif I was obviously tired when writing this... s/+fi/+endif/
Assignee | ||
Comment 3•14 years ago
|
||
builds fine locally (with my full patch stack), will run through try once I get that setup.
Attachment #432482 -
Attachment is obsolete: true
Attachment #433009 -
Flags: review?(kairo)
Assignee | ||
Comment 4•14 years ago
|
||
We actually shouldn't revert the $(abspath change I did from the other bug; it doesn't have a 1.9.2 landing, but this machinery should all work anyway. (Try will tell)
Attachment #433010 -
Flags: review?(kairo)
Comment 5•14 years ago
|
||
Comment on attachment 433009 [details] [diff] [review] v1.1 This v1.1 is obsolete, I guess?
Updated•14 years ago
|
Attachment #433010 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 433009 [details] [diff] [review] v1.1 yes, obsolete.
Attachment #433009 -
Attachment is obsolete: true
Attachment #433009 -
Flags: review?(kairo)
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #4) > Created an attachment (id=433010) [details] > v1.2 > > We actually shouldn't revert the $(abspath change I did from the other bug; it > doesn't have a 1.9.2 landing, but this machinery should all work anyway. (Try > will tell) To be clear on this, I'm just waiting for a few patches to be sr'ed by standard8 so I have to unbitrot this or those patches by pushing early.
Assignee | ||
Comment 8•14 years ago
|
||
Pushed as: http://hg.mozilla.org/comm-central/rev/ad08c4e0a3c6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•14 years ago
|
||
Repushed-as http://hg.mozilla.org/comm-central/rev/f903ba8ca1b4 (hope this sticks)
Reporter | ||
Updated•14 years ago
|
Attachment #433010 -
Attachment description: v1.2 → v1.2
[Checkin: Comment 10]
Reporter | ||
Comment 11•14 years ago
|
||
V.Fixed, per tinderboxes. I updated http://dev.seamonkey.at/?d=x&i=mozilla&m=c too ;-)
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
Reporter | ||
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•