481057 - Implement MEDIA_ERR_DECODE machinery

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

We need to implement the part of the spec that covers the "if the media data is corrupted" case.  This was implemented (partially?) as part of another patch, but this part never made it into the tree for reasons I can't remember now.

Comment 1

[Matthew Gregan [:kinetik]]

Bug 449159 comment 47 and bug 449159 comment 51 (which I can't find a bug for, so I guess might have just gotten lost).

The Wave decoder already tries to fire an error for this case, but it's stubbed out in nsWaveDecoder::MediaErrorDecode.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Initial patch.  Still need to make the Ogg decoder fire decode errors.  This patch also renames MEDIA_ERR_NONE_SUPPORTED to MEDIA_ERR_SRC_NOT_SUPPORT per the spec.

Comment 3

[Matthew Gregan [:kinetik]]

Er, that'd be MEDIA_ERR_SRC_NOT_SUPPORTED.

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: patch v1

Rebased against trunk, uses new test infrastructure, adds tests for Ogg decoder and constants.

Needs superview because it modifies web-exposed IDL.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 399149 [details] [diff] [review]
patch v1

Looks good. The only issue is whether we can make the test ogg file smaller.

Comment 7

[Matthew Gregan [:kinetik]]

Attachment: patch v2

Same, but with the FLAC stripped out of the test file (saves ~200kB) and renamed from dirac_flac.ogg to dirac.ogg, some minor changes to the test, and slightly improved (but still not great) comments on gErrorTests and gDecodeErrorTests in manifest.js.

Comment 8

[Matthew Gregan [:kinetik]]

http://hg.mozilla.org/mozilla-central/rev/55932a3a32aa

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d7d1b859f642