Closed Bug 481065 Opened 15 years ago Closed 15 years ago

local folder db's opened on startup

Categories

(MailNews Core :: Backend, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

(Blocks 1 open bug)

Details

(Keywords: perf, regression)

Attachments

(1 file)

fixing bug 469448 (or, rather, fixing it w/o breaking tests) led to a regression where we opened up folder dbs for sub-folders on startup. This fixes that regression.
Attached patch proposed fixSplinter Review
the fix is to move the code that forces us to open the db into the same if clause that we hit if the folder doesn't exist (which is what the test code runs into).
Attachment #365060 - Flags: superreview?(bugzilla)
Attachment #365060 - Flags: review?(bugzilla)
Blocks: 469448
Keywords: perf
Attachment #365060 - Flags: superreview?(bugzilla)
Attachment #365060 - Flags: superreview+
Attachment #365060 - Flags: review?(bugzilla)
Attachment #365060 - Flags: review+
fix checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
likely Bug 491130 is fixed by this.

(can't remember if bienvenu and I discussed tests on IRC, so....) 
Is the best approach to detect regression like to rely on TS tests?  If so, we need to make sure TS tests have sufficient subfolders.  And if not, do what type of tests do we need?
Flags: in-testsuite?
Target Milestone: --- → Thunderbird 3.0b3
Do the TS tests actually create msf files for folders, or run against profiles that have .msf files? This bug in particular was about opening .msf files that existed on startup, which is something that afaik, none of our tests are good at catching.
Blocks: 478595
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: