481241 - Replace auto-incrementing collection IDs with UUIDs

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

For security reasons, we'd like to replace the current auto-incrementing IDs used by collections with UUIDs.

Les, do you mind taking a look at this?

Comment 1

[Les Orchard [:lorchard]]

Attachment: UUID added to collection fields, swapped out references to ID for UUID

Here's a patch that I think does the trick, looking for a reviewer since rdoherty's out

Comment 2

[Les Orchard [:lorchard]]

Comment on attachment 366957 [details] [diff] [review]
UUID added to collection fields, swapped out references to ID for UUID

tossing an r? to clouserw, since rdoherty's out.  hopefully the addons bandwagon branch doesn't give too much trouble

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 366957 [details] [diff] [review]
UUID added to collection fields, swapped out references to ID for UUID

Tested, looks good and works well.

Comment 4

[Ryan Doherty (:rdoherty)]

Comment on attachment 366957 [details] [diff] [review]
UUID added to collection fields, swapped out references to ID for UUID

FYI the lines:

+-- ALTER TABLE `collections` ADD `uuid` CHAR(36) NOT NULL DEFAULT '';
+-- UPDATE `collections` SET `uuid`=uuid() WHERE `uuid`='';
+-- ALTER TABLE ADD UNIQUE KEY `uuid` (`uuid`);

I assumed weren't part of the patch. 'ALTER TABLE ADD UNIQUE KEY `uuid` (`uuid`);' should be 'ALTER TABLE `collections` ADD UNIQUE KEY `uuid` (`uuid`);'

Comment 5

[Les Orchard [:lorchard]]

checked in as r23586

Yeah, those lines are meant for the database updates page.  Forgot I left them in there, but wanted to keep track of them because the order is a little tricky to ensure that there are unique values already present before adding a unique key.