481409 - [Extension] Allow user to unsubscribe from a collection

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Brian King [:kinger]]

At the top of a collection listing on the right side of the Add-ons Subscriptions tab, we now have 2 links - View Collection | Unsubscribe. 

Tasks for this bug:

1) Hook up correct View Collection URL
2) Review Unsubscribe, and consider a confirmation dialog similar to what we will have in Prefs.
3) Under certain circumstances, one or both of these links needs to be disabled. feedsPaneController.js already does this, but was designed for when the links were buttons. Determine if that code still works for labels, and if not change it.

Comment 1

[David McNamara [:mackers]]

See my comments here:

https://bugzilla.mozilla.org/show_bug.cgi?id=481149#c8

Comment 2

[David McNamara [:mackers]]

1) The "View Collection" and "Unsubscribe" links are now in place and working.

2) Should this be in the extension or on the site? It would seem strange to have a confirm box to open the unsubscribe url in the browser.

3) What circumstances can you think of?

Comment 3

[Brian King [:kinger]]

(In reply to comment #2)
> 2) Should this be in the extension or on the site? It would seem strange to
> have a confirm box to open the unsubscribe url in the browser.

Better on the site I think. Justin?
 
> 3) What circumstances can you think of?

Actually I was thinking in the old panel we had that those links were visible when no feeds were subscribed to. Now in that case, the whole panel is taken over and the links are not visible. Once it is the case that a subscription is always selected, then I suppose they don't need to be disabled.

Comment 4

[Justin Scott [:fligtar]]

Hmm, how about this:

When Unsubscribe is clicked, a confirmation box says:

 ---------------------------------------------------------------
| Unsubscribing from this collection will also remove it from   |
| your list of favorites. Are you sure you want to unsubscribe? |
|                                                               |
|                              [No, cancel]  [Yes, unsubscribe] |
 ---------------------------------------------------------------

When yes is clicked, the XHR is sent to unsubscribe and the feed is removed from the UI. I don't think we should involve displaying a website here at all.

Comment 5

[Brian King [:kinger]]

I think we also need the same thing in Manage Subscriptions in Prefs, just to be consistent.

Comment 6

[David McNamara [:mackers]]

The problem with this approach is that there is no XHR call for unsubscribe...

Comment 7

[David McNamara [:mackers]]

I have added the UI strings for unsubscribe (and login).

r24254.

Comment 8

[Justin Scott [:fligtar]]

Moving to revised M5 milestone (4/28).

Comment 9

[David McNamara [:mackers]]

Added this functionality. User can unsubscribe from extension manager pane and from settings.

r24534

(Also fixed a bug which was showing *all* user's collections, as opposed to just subscribed).

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the 0.4 version of the extension, against comment 4.