481527 - rework tab preview logic to always use drawImage, also do drawing from CanvasBrowser

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

Should take visibleBounds into account when doing drawImage onto the preview,

Also don't update tab previews when closing tabs, etc.

Comment 1

[(dormant account)]

Attachment: preliminary patch

This does what I want. I nuked all drawWindow calls(which often didn't work anyways). tab drawing is lazy.

Still need to ensure that offscreen parts of the canvas aren't copied as those may not be flushed at the time of thumbnailing.

Comment 2

[(dormant account)]

Attachment: wfm

This patch now does what I expect. Bugs fixed
a) When pressing newtab while firstrun is loaded, wrong tab preview is drawn
Triggered by the page drawing happening after tab is drawn.

b) when loading m.endgadget.net wrong tab preview is drawn
mozafterpaint triggers too late for fast-loading pages

c) Don't use drawWindow
c-II) Don't drawWindow every bloody tab when closing a tab high in the tab list

d) should be a small speed gain as tab painting now happens lazily in preparation for a pan.

e) tab preview is wrong during page load(ie only gets updated when a page finishes loading)

f) The tab drawing code is half of what it was before.

g) I really shouldn't be using an alphabetic list for this.

Comment 4

[Stuart Parmenter]

Comment on attachment 369729 [details] [diff] [review]
wfm

please keep the thumbnail knowledge out of the CanvasBrowser code -- move it to browser.js and simply add a drawTo(dest) function to CanvasBrowser

Comment 5

[(dormant account)]

the code in question changed so this doesn't apply