Closed Bug 481864 Opened 15 years ago Closed 15 years ago

new tab button doesn't lighten when Firefox loses focus

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: beltzner, Assigned: mstange)

References

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy] [polish-visual][polish-p1])

Attachments

(2 files, 1 obsolete file)

screenshot
48.49 KB, image/png
Details
v2
580 bytes, patch
dao
: review+
Details | Diff | Splinter Review
Attached image screenshot — 
See screenshot. Since the landing of bug 480180, the new "new tab" button doesn't appear to de-saturate when the application loses focus.
Flags: blocking-firefox3.1+
Alex: I'll let you tag this as polish, but I marked it blocking because right now it's a pretty significant visual regression from 3.0.x
Priority: -- → P2
Whiteboard: [polish-easy] [polish-visual]
Attached patch fix (obsolete) — — Splinter Review 
Dão, you could just have moved the selector to the right rule in http://hg.mozilla.org/mozilla-central/rev/6fe383bb61e5 ;-)
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #366336 - Flags: review?(dao)
Comment on attachment 366336 [details] [diff] [review]
fix

Don't we need that for both .tabs-newtab-buttons, and only for the icon?
Attachment #366336 - Flags: review?(dao) → review-
...good point. How come I didn't notice that?
Attached patch v2 — — Splinter Review 

        Attachment #366336 -
        Attachment is obsolete: true

        Attachment #366381 -
        Flags: review?(dao)

    
  

        Attachment #366381 -
        Flags: review?(dao) → review+

    
    

    
  
pushed: http://hg.mozilla.org/mozilla-central/rev/e5207ec2d2c5
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1

    
    

    
  
Verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090311 Minefield/3.2a1pre as well as the latest 10.4 nightly.
Status: RESOLVED → VERIFIED

    
    

    
  
Comment on attachment 366381 [details] [diff] [review]
v2

We'd like to see this polish bug land on 1.9.1, so requesting approval.

        Attachment #366381 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 366381 [details] [diff] [review]
v2

This bug is blocking and thus free to land on branch.

        Attachment #366381 -
        Flags: approval1.9.1?

    
    

    
  
verified FIXED on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090513 Shiretoko/3.5b5pre ID:20090513034609
Keywords: fixed1.9.1 → verified1.9.1

    
    

    
  
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p1]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: