480180 - Widen the new tab button on OS X

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Mockup of the new tab button on OS X

We should make the new tab button on OS X visually 32 pixels wide.  This is similar to other platforms, matches the width of the site and search buttons, and makes the button a little easier to target and hit.  It isn't currently visually 32 pixels wide due to the images we use for tabs on OS X making it appear smaller.  Details in the attached mockup.

Comment 1

[Dão Gottwald [:dao]]

Attachment: wip

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 365176 [details] [diff] [review]
patch

>diff --git a/browser/themes/pinstripe/browser/browser.css b/browser/themes/pinstripe/browser/browser.css

>-.tabbrowser-tab:not(:hover):not([selected="true"]) > .tab-icon-image,
>-.tabbrowser-arrowscrollbox > .tabs-newtab-button:not(:hover) > .toolbarbutton-icon {
>+.tabbrowser-tab:not(:hover):not([selected="true"]) > .tab-icon-image {
>   opacity: .6;
> }

I don't really see any mention of losing the hover effect in the mockup, but I suppose it is less translucent by default. Alex?

Comment 4

[Dão Gottwald [:dao]]

That's based on reverse engineering attachment 364166 [details] -- the icon doesn't seem to be faded there, otherwise it would be really dark (i.e. black) on hover.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

>I don't really see any mention of losing the hover effect in the mockup, but I
>suppose it is less translucent by default. Alex?

I can't really find any other instance of a hover effect icon change on OS X (do you know of any?), so I think it makes sense to drop the hover effect.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/8948ec7f8195

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9c727ab31a7d

Comment 9

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090309 Minefield/3.2a1pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090310 Shiretoko/3.1b4pre Ubiquity/0.1.5

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.