482068 - ###!!! ASSERTION: sqlite3_close failed. There are probably outstanding statements that are listed above! running places xpcshell tests in debug builds

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jeff Walden [:Waldo]]

/Users/jwalden/moz/2/testing/xpcshell/test_all.sh: line 130: 27936 Abort trap              NATIVE_TOPSRCDIR="$native_topsrcdir" TOPSRCDIR="$topsrcdir" $xpcshell -j -s $headfiles -f $t $tailfiles 2>$t.log 1>&2
TEST-UNEXPECTED-FAIL | ../../../../_tests/xpcshell/test_places/sync/test_database_sync_expireAllFavicons.js | test failed, see log
../../../../_tests/xpcshell/test_places/sync/test_database_sync_expireAllFavicons.js.log:
>>>>>>>
*** test pending
*** test pending
*** test finished
*** running event loop
*** test finished
*** exiting
WARNING: SQL statement 'SELECT id FROM moz_places_view WHERE favicon_id NOT NULL' was not finalized: file /Users/jwalden/moz/2/storage/src/mozStorageConnection.cpp, line 254
WARNING: SQL statement 'SELECT id FROM moz_favicons' was not finalized: file /Users/jwalden/moz/2/storage/src/mozStorageConnection.cpp, line 254
WARNING: SQL statement 'SELECT id FROM moz_places_temp WHERE url = :url AND favicon_id NOT NULL' was not finalized: file /Users/jwalden/moz/2/storage/src/mozStorageConnection.cpp, line 254
WARNING: SQL statement 'SELECT id FROM moz_places WHERE url = :url AND favicon_id NOT NULL' was not finalized: file /Users/jwalden/moz/2/storage/src/mozStorageConnection.cpp, line 254
###!!! ASSERTION: sqlite3_close failed. There are probably outstanding statements that are listed above!: 'Error', file /Users/jwalden/moz/2/storage/src/mozStorageConnection.cpp, line 267
NSGetModule+0x00003356 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libstoragecomps.dylib +0x0000502A]
NS_InvokeByIndex_P+0x00000062 [../../../../dist/bin/libxpcom_core.dylib +0x0007D4EC]
NSGetModule+0x00012F76 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libxpconnect.dylib +0x00040BD4]
NSGetModule+0x0001B45C [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libxpconnect.dylib +0x000490BA]
js_Invoke+0x00000911 [../../../../dist/bin/libmozjs.dylib +0x0008C7E7]
JS_CompareValues+0x00017348 [../../../../dist/bin/libmozjs.dylib +0x00079962]
js_Invoke+0x0000099B [../../../../dist/bin/libmozjs.dylib +0x0008C871]
NSGetModule+0x0000D83D [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libxpconnect.dylib +0x0003B49B]
NSGetModule+0x0000572F [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libxpconnect.dylib +0x0003338D]
NS_InvokeByIndex_P+0x0000031C [../../../../dist/bin/libxpcom_core.dylib +0x0007D7A6]
NS_InvokeByIndex_P+0x0000037A [../../../../dist/bin/libxpcom_core.dylib +0x0007D804]
NS_SetGlobalThreadObserver(nsIThreadObserver*)+0x0000075D [../../../../dist/bin/libxpcom_core.dylib +0x0006A9E5]
NS_InvokeByIndex_P+0x00000062 [../../../../dist/bin/libxpcom_core.dylib +0x0007D4EC]
NSGetModule+0x00012F76 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libxpconnect.dylib +0x00040BD4]
NSGetModule+0x0001B45C [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/dist/bin/components/libxpconnect.dylib +0x000490BA]
js_Invoke+0x00000911 [../../../../dist/bin/libmozjs.dylib +0x0008C7E7]
JS_CompareValues+0x00017348 [../../../../dist/bin/libmozjs.dylib +0x00079962]
js_FreeStack+0x00001092 [../../../../dist/bin/libmozjs.dylib +0x0008B238]
JS_ExecuteScript+0x00000082 [../../../../dist/bin/libmozjs.dylib +0x00015FE0]
tart+0x000016EB [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/toolkit/components/places/tests/../../../../dist/bin/xpcshell +0x000031B3]
tart+0x00001A26 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/toolkit/components/places/tests/../../../../dist/bin/xpcshell +0x000034EE]
tart+0x000020A8 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/toolkit/components/places/tests/../../../../dist/bin/xpcshell +0x00003B70]
tart+0x00004162 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/toolkit/components/places/tests/../../../../dist/bin/xpcshell +0x00005C2A]
tart+0x00000102 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/toolkit/components/places/tests/../../../../dist/bin/xpcshell +0x00001BCA]
tart+0x00000029 [/Users/jwalden/moz/2/obj-i386-apple-darwin8.11.1/toolkit/components/places/tests/../../../../dist/bin/xpcshell +0x00001AF1]

<<<<<<<

Easy to fix, patch forthcoming once I get a bug number for this bug -- but please do watch for this error in the future when writing/reviewing such patches.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Finalize statements after use

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> Easy to fix, patch forthcoming once I get a bug number for this bug -- but
> please do watch for this error in the future when writing/reviewing such
> patches.
It didn't use to assert - bug 479543 changed how we warn about it.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 366128 [details] [diff] [review]
Finalize statements after use

r=sdwilsh

Comment 4

[Jeff Walden [:Waldo]]

Ah, right,  I assumed it was after but didn't check the landing time.

Somebody please check this in for me, I don't even have enough net access now to access Bugzilla (but, oddly, I have enough to ssh into MIT).  Please do fix the commit message I forgot to edit after submitting the patch, too.  :-)

Comment 5

[Marco Bonardo [:mak]]

just FYI the fix was already in bug 480873

Comment 6

[Marco Bonardo [:mak]]

pushed by waldo
http://hg.mozilla.org/mozilla-central/rev/50169589cc51

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv