482203 - NullPointerException capturing a continuation

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Attila Szegedi]

Up to 1.7R1, I used to terminate an interpreter by capturing a continuation at the top scope level, and then invoking it when necessary. With HEAD though, now I'm getting a NullPointerException:

Exception in thread "main" java.lang.NullPointerException
	at org.mozilla.javascript.Interpreter.captureContinuation(Interpreter.java:2945)
	at org.mozilla.javascript.Interpreter.interpretLoop(Interpreter.java:1729)
	at org.mozilla.javascript.Interpreter.interpret(Interpreter.java:845)
	at org.mozilla.javascript.InterpretedFunction.call(InterpretedFunction.java:164)
	at org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:405)
	at org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3066)
	at org.mozilla.javascript.Context.callFunctionWithContinuations(Context.java:1199)
	at org.mozilla.javascript.Context.executeScriptWithContinuations(Context.java:1166)
	at org.szegedi.rhinotest.ContinuationsTest17.main(ContinuationsTest17.java:20)

I've attached a ZIP file with two Java test files and one .js file - the first Java class (suffixed 16) works against all 1.6 Rhino releases that support continuations, as well as 1.7R1. The second Java class (suffixed 17) uses the 1.7R2 continuations API, and throws a NPE.

Is this a bug, or am I doing something wrong?

Comment 1

[Attila Szegedi]

Attachment: A Zip file with tests

Comment 2

[Norris Boyd]

Fixed:

Checking in src/org/mozilla/javascript/Interpreter.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/Interpreter.java,v  <--  In
terpreter.java
new revision: 1.355; previous revision: 1.354
done
RCS file: /cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/tests/Bug4822
03.java,v
done
Checking in testsrc/org/mozilla/javascript/tests/Bug482203.java;
/cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/tests/Bug482203.java,v
 <--  Bug482203.java
initial revision: 1.1
done

and in release branch:

Checking in src/org/mozilla/javascript/Interpreter.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/Interpreter.java,v  <--  Interpreter.java
new revision: 1.349.2.5; previous revision: 1.349.2.4
done