482342 - add browser=firefox3.5 support to SHOWFOR

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

Firefox 3.1 is being reversioned to 3.5, so we need {SHOWFOR(browser=firefox3.5)} to work. It should also be included in browser=firefox3.

Comment 1

[David Tenser [:djst]]

Important that firefox3.1 is still kept though; otherwise we'll need to update all KB articles at the same time as we push this live. Better to support both.

Comment 2

[E. Cooper [:ecooper]]

So, 3.1 (firefox3.1) should become an alias to 3.5 (firefox3.5)?

That's not a problem.

Comment 3

[David Tenser [:djst]]

Exactly right. And no, likely not a problem. Let's just do it! ;)

Comment 4

[E. Cooper [:ecooper]]

Attachment: Add 3.5 support v1

This adds showfor support for 3.5. 

With this patch, 3.1 becomes an alias for 3.5. So, any showfor blocks currently using ff3.1, fx3.1, or firefox3.1 will show up for 3.5. firefox3, ff3, and fx3 content will show up for 3.5 just like it did for 3.1 as well. Oh, firefox3.5 is usable too, of course.

Chris/David does that sound about right?

I also took the opportunity to refactor some of the original showfor code to make it a slightly more maintainable.

Comment 6

[Chris Ilias [:cilias]]

That sounds right.

Your "I also took the opportunity to refactor some of the original showfor code" concerns me.  But I'll leave that for a code reviewer.

Comment 7

[E. Cooper [:ecooper]]

r24101/r24102

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; 3.5 detection works, and we're testing the variants over in bug 482347.