482347 - make SHOWFOR UA detection work with both 3.1 and 3.5

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

Firefox 3.1 is being reversioned to Firefox 3.5. SHOWFOR should be updated for 3.5, but we don't want to break UA detection on builds labeled as 3.1. So if the UA is either 3.1 or 3.5, Firefox 3.5 content will be displayed.

Comment 1

[E. Cooper [:ecooper]]

Attachment: Add UA detection for 3.5 v1

Firefox 3.1 and 3.5 will be pointed to 3.5.

Testing this will need the patch from bug 482342. Or you can test by running 'showfor_detect_browser()' in the Firebug console.

Comment 2

[E. Cooper [:ecooper]]

r24107/r24108

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Chris, do you have any good articles that use this, so I can test?  Would you mind taking a look too?  Thanks!

Comment 4

[Majken Connor [:Kensie]]

added testing link to URL field

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Krupa; mind giving this a shot?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

So far I've tested:

* On Windows: Firefox 2.0.0.20, Firefox 3.0, Firefox 3.0.5, Firefox 3.0.8, Firefox 3.1 beta 3, Shiretoko
* On Mac: Firefox 3.0.8, Shiretoko

All good so far; I note that non-Firefox-based browsers default to 3.0; is that expected?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Linux:  Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 is good too.

Comment 8

[David Tenser [:djst]]

(In reply to comment #6)
> All good so far; I note that non-Firefox-based browsers default to 3.0; is that
> expected?

Yes, that's expected. Once 3.5 is officially released, that should change though.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED: I've checked 3.1 beta 3 on Mac as well as 2.0.0.20, too.