Closed Bug 482350 Opened 17 years ago Closed 16 years ago

Make a Camino-like about.css to replace the winstriped pinstripe version

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alqahira, Assigned: phiw2)

References

Details

(Whiteboard: [camino-2.0])

Attachments

(1 file, 1 obsolete file)

about-css v2
1.34 KB, patch
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review
From bug 390104: > 2) about.css is a new file, and in toolkit/themes/pinstripe it comes from > winstripe; we'll need to port a few changes from our netError.css/config.css > style and make a new Camino-like about.css (used for about:credits and friends).
Based on the list in about:about, these would be the only files affected ? about:credits about:license about:buildconfig And possibly (breakpad ?) - although the Minefield/Fx3.0.x version links to dirlistings.css - about:crashes note 1 - about:buildconfig and about:license file do NOT contain any link to chrome://global/skin/about.css - only about:credits links to about.css That is the same situation as for Firefox 3.0.x - Gecko 1.9.0 - all 3 files in Minefield/Shiretoko have a class 'aboutPageWideContainer' appended to the <body> element, and link to about.css. note 2 a possible Camino about.css would - match background, color and font(-size) settings of config.css, and match the border/border-radius - would it include a Camino logo ? --- - about: buildconfig needs some special attention, as the file is in quirks mode
Camino about.css with the most minimal changes: - matching the border & border-radius from net-error.css - matching font-size & font-weight for the h1 preview http://dev.l-c-n.com/camino/about/about_credits.html screenshot http://dev.l-c-n.com/camino/about/about-credits_minimal.png ---- alternate option, some more changes (additional Camino logo) http://dev.l-c-n.com/camino/about/about_credits2.html screenshot http://dev.l-c-n.com/camino/about/about-credits2.png what about:buildconfig eventually may look like http://dev.l-c-n.com/camino/about/about_buildconfig.html screenshot http://dev.l-c-n.com/camino/about/about-buildconfig2.png But that part needs more massaging, to convince Camino to use a forked file...
Attached patch about.css (obsolete) — — Splinter Review
Camino specific about.css with minimal changes I think I got cvsdo working correctly...
Attachment #402786 - Flags: review?
I like the color and rule in the in the alternate version; less sure about the Camino logo in it, though.
(In reply to comment #4) > I like the color and rule in the in the alternate version; less sure about the > Camino logo in it, though. Maybe a minimal change with a touch of colour ? http://dev.l-c-n.com/camino/about/about_test3.html
Attached patch about-css v2 — — Splinter Review
The differences with the winstriped pinstripe version are - matching the border & border-radius from net-error.css (#aboutPageContainer) - styling of the h1 (!important on text-align, the html file has a style-block in the <head>)
Attachment #402786 - Attachment is obsolete: true
Attachment #403920 - Flags: superreview?
Attachment #403920 - Flags: review?(alqahira)
Attachment #402786 - Flags: review?
Comment on attachment 403920 [details] [diff] [review] about-css v2 Looks good; r=ardissone No clue how the original file got past Gerv without the license boilerplate, but that's really not our problem :P
Attachment #403920 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #403920 - Flags: superreview?
Attachment #403920 - Flags: review?(alqahira)
Attachment #403920 - Flags: review+
Comment on attachment 403920 [details] [diff] [review] about-css v2 sr=smorgan
Attachment #403920 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed on cvs trunk and CAMINO_2_0_BRANCH.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: