Closed Bug 482466 Opened 11 years ago Closed 11 years ago

Hook activity manager into the new alert/error listening mechanism

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In bug 481431 I implemented a server/listener mechanism for front-end items so we can provide a different alert method and get rid of modal dialogs.

This is the next step in that process - hook the activity manager into the new mechanism so that it can log warnings, but still let the back-end alert modal. Bug 476696 can then come along and implement "poptarts".

We probably need to have more information on the warnings, but this first basic version gives us something to work with and to start assessing what we're going to be getting (as some of the back-end alerts don't currently make it to the UI if they were instigated by a background process).
Flags: blocking-thunderbird3+
Attachment #366554 - Flags: ui-review?(clarkbw)
Attached patch The fixSplinter Review
Attachment #366555 - Flags: review?(mkmelin+mozilla)
Whiteboard: [has patch][needs review mkmelin,clarkbw]
Status: NEW → ASSIGNED
Comment on attachment 366555 [details] [diff] [review]
The fix

>+// This module provides a link between the send later service and the activity
>+// manager.

I guess this could be /** */ style


>+    let msgMailSession = Cc["@mozilla.org/messenger/services/session;1"]
>+                             .getService(Ci.nsIMsgMailSession);

Align dot under [ ?

r=mkmelin
Attachment #366555 - Flags: review?(mkmelin+mozilla) → review+
Whiteboard: [has patch][needs review mkmelin,clarkbw] → [has patch][needs review clarkbw]
Attachment #366554 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 366554 [details]
Current Warning in Activity Manager (Mac)

looks like a good start. (pasting from IRC)

My suspicion is that we'll want to keep those errors a part of the mail connect process since as events I assume multiples will accumulate  and become less useful over time.  

You're right that this will be a good experiment to understand if that's going to be an issue.
Checked in: http://hg.mozilla.org/comm-central/rev/396db78216fc

I'm going to mark this as fixed and we'll see how we go with errors appearing and probably cover tidy up/extensions in separate bugs.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][needs review clarkbw]
You need to log in before you can comment on or make changes to this bug.