48248 - Extraneous declaration of putenv() in unix_rand.c.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

This bug was reported by Steven T. Hatton
<[e-mail]> in mozilla.crypto.

This is the compiler error he gets.

In file included from sysrand.c:36:
unix_rand.c:267: conflicting types for `putenv'
/usr/include/stdlib.h:540: previous declaration of `putenv'

/usr/include/stdlib.h has:

extern int putenv __P ((char *__string));

/mozilla/security/nss/lib/util/unix_rand.c has:

int putenv(const char *);

Since putenv() is declared in <stdlib.h> and unix_rand.c
already includes <stdlib.h>, we should remove the line
int putenv(const char *);
from unix_rand.c.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

The real solution to this bug is to eliminate these functions from NSS
and start using the versions of these functions in NSPR.

Or is this bug about the versions in NSPR?
I can't tell.

Comment 2

[Wan-Teh Chang]

This bug is about unix_rand.c in NSS.

We should open another bug for what you suggested:
eliminate these functions from NSS and start using
the versions of these functions in NSPR.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Why should that be a separate bug?  Why not kill 2 birds with one stone?

Comment 4

[Wan-Teh Chang]

I removed the putenv() declaration from unix_rand.c.
/cvsroot/mozilla/security/nss/lib/util/unix_rand.c, revision: 1.2

Comment 5

[Wan-Teh Chang]

Just wanted to note that Ian opened bug #48258
for NSS to use PR_GetRandomNoise().