482506 - increment_i and inclocal_i don't convert double to int on increment

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P2)

Description

[Tom Harwood]

Attachment: Assembly testcase

Per AVM2 spec, increment_i and inclocal_i convert their input to int before incrementing.

Repro case will be in abcasm/coverage tests "I" marked expectedfail.

Comment 1

[Lars T Hansen]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=478179.

(When logging these bugs, please be sure to specify whether it's interpreter or JIT that's failing.)

Comment 2

[Tom Harwood]

Good idea re: JIT and interp.  Both modes fail on my box; note that my system does declocal_i correctly bug some buildbot systems fail.

Did you have a different bug in mind?  478179 is a font problem.

Comment 3

[Lars T Hansen]

Sorry, 478197, I'm mildly dyslexic with numbers.  There was a better than 50% chance that I would have transposed two digits, and I did :-)

https://bugzilla.mozilla.org/show_bug.cgi?id=478197

Comment 4

[Lars T Hansen]

Note that this is an interpreter-only failure, the jit failed to compile the "I" tests but this has now been fixed.

Depends on Box conversion because that will alter the code paths in the interpreter.

Comment 5

[Steven Johnson]

fixed in changeset:   2006:d5654b2ac8b2