482564 - [or] Search engine setup for Firefox 3.5 for Oriya.

Status: RESOLVED FIXED

(Mozilla Localizations :: or / Odia, defect)

Description

[Seth Bindernagel]

We want to ship Firefox 3.5 a good list of search engines for Oriya. 

We're going to work towards this in three phases. First, the localization team and Stas (Stas Malolepszy) will look at the market for the language and come up with a good set of search providers. Manoj, we'll need your input on this, the guidelines for making recommendations are on http://wiki.mozilla.org/Firefox_web_services_guidelines. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo, Amazon, Answers, CC, eBay, Wikipedia

After we decided on a particular search engine, Stas will contact the owner and ask for permission, and for specifics like proper search flags. undefined, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Oriya should look like, the localization team and Stas will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them.

Please don't commit any modifications in l10n/or/browser/searchplugins to the cvs repository without a patch reviewed by Stas, Axel or someone else appointed by Stas or SethB. The data here is sensitive to users and our search partners, thus the extra care here.

Comment 1

[Seth Bindernagel]

Hi Manoj:  Any progress here?  We would love to have you participate as a
beta in FF 3.5 beta 4 and will need to provide recommended search plugins for
Oriya to ensure participation.  Please let us know.  Thanks!

Comment 2

[Manoj Kumar Giri]

Attachment: Updated Searchplugins files

As per the requirement modified the searchplugins files for Oriya (or).

Comment 3

[Seth Bindernagel]

Thanks, Manoj.  Stas, can you review this patch please?

Comment 4

[Staś Małolepszy :stas]

Hi Manoj. Before we move on to creating patches, let's discuss the possible choices. I see that you've chosen the following search engines to include in your attachment:

* amazondotcom
* eBay-in
* google
* yahoo-in
* wikipedia-or

That's a good start. Do you have any other suggestions for search engines available in Oriya? Typically, we try to include two search engines in each category (two generic search, two e-commerce, and two specific interest). Any ideas?

Comment 5

[Manoj Kumar Giri]

Hi 
       I've no idea on other search engines. For the time being we can go for these search engines. Later on i can suggest if i got anything from other community members.

Thanks
Manoj

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 369467 [details]
Updated Searchplugins files

Thanks Manoj. Let's proceed as you suggest. Putting the attachment in my review queue.

Comment 7

[Manoj Kumar Giri]

(In reply to comment #6)
> (From update of attachment 369467 [details])
> Thanks Manoj. Let's proceed as you suggest. Putting the attachment in my review
> queue.

Thanks Stas.

Comment 8

[Staś Małolepszy :stas]

Comment on attachment 369467 [details]
Updated Searchplugins files

Hi Manoj. The attached files look good, but there are two things that will have to be fixed:

* in ebay-in.xml, please remove the code for the second plug-in. The one that should stay is the one using rover.ebay.com as the url's template.

* in wikipedia-or.xml, you left "hi" in <Url type="application/x-suggestions+json" method="GET" template="http://hi.wikipedia.org/w/api.php">

For these two reason I'm giving a r-. It should be easy to fix though. Can I ask you to create a patch this time and attach it to this bug? You can simply modify the files locally and then issue | hg diff | to create the patch.

Thanks!

Comment 9

[Manoj Kumar Giri]

Attachment: Created a new patch for updating searchplugins for Oriya (or)

Hi,

Can somebody please review & approve it?

Manoj

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 378310 [details] [diff] [review]
Created a new patch for updating searchplugins for Oriya (or)

Two more comments:

The title of the wikipedia plugin should be "Wikipedia (or)" to match the site.

list.txt should list the en-US plugins
google
amazondotcom
but you don't need the actual xml files, those are picked up from en-US during the build.

Comment 11

[Manoj Kumar Giri]

Attachment: Updated Searchplugins files

Created a new patch after modifying the searchplugins for Oriya (or)

Comment 12

[Manoj Kumar Giri]

Comment on attachment 378323 [details] [diff] [review]
Updated Searchplugins files

Pike,
Please Review it again.
 
Thanks
Manoj

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 378323 [details] [diff] [review]
Updated Searchplugins files

r=me, please land with a check-in comment referencing this bug and my and Stas' review. Something like "bug 482564, switch to ebay.in and yahoo.in, or.wikipedia.org, drop creativecommons, r=stas,[e-mail]" would be good.

Comment 14

[Manoj Kumar Giri]

Landed http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/or/rev/084588929ac9

Comment 15

[Axel Hecht [:Pike]]

http://hg.mozilla.org/l10n-central/or/rev/084588929ac9, FIXED.