482670 - WBORecord should implement a .deleted property

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P2)

Description

[Dan Mills [:thunder]]

WBORecord should have a .deleted property.  When serializing, we can check if it's meant to represent a deleted item and if so hardcode a null payload.

When deserializing, we can look at the payload and set .deleted appropriately.

This will make the code more readable (foo.deleted vs foo.payload === null), and it would make it easier to move to a different serialization format, if we ever wish to do that.

Comment 1

[Dan Mills [:thunder]]

-> 0.4

Comment 2

[Ed Lee :Mardak]

Would the payload actually be null or empty string? I thought the server requires a string.?

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/03a08e4e576e

Expose a .deleted property that engines can set to true to store an even thinner deleted payload (empty string "" instead of "[null]") on the server. Handle deserializing of deleted records by setting the property. Note: Engines must set their payloads to something JSON-able if it's not a delete record.