Closed
Bug 482692
Opened 14 years ago
Closed 14 years ago
Should be able to override -moz-border-colors with border-color
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a2
People
(Reporter: dao, Assigned: dbaron)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
11.40 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Take http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/textbox.css for example. It uses -moz-border-*-colors, and whenever you use -moz-appearance:none to manually style a particular textbox, you have to use -moz-border-*-colors even if you only want a single color on each side. That's annoying.
Assignee | ||
Comment 1•14 years ago
|
||
Making border-left-color, etc., into shorthands would be a good bit of a pain. I'm not sure if it's worth it. I'd note that you can use -moz-border-*-colors: none to turn off that behavior and use border-*-color again.
Reporter | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > I'd note that you can use -moz-border-*-colors: none to turn off that behavior > and use border-*-color again. But I can't do: -moz-border-colors: none; border: 1px solid red; since there's no -moz-border-colors shorthand, right? So this is hardly better: -moz-border-top-colors: none; -moz-border-right-colors: none; -moz-border-bottom-colors: none; -moz-border-left-colors: none; border: 1px solid red; than: border: 1px solid; -moz-border-top-colors: red; -moz-border-right-colors: red; -moz-border-bottom-colors: red; -moz-border-left-colors: red; Even if there was a -moz-border-colors shorthand, I'm not sure that "none" is helpful, because this: -moz-border-colors: none; border: 1px solid red; doesn't seem like a great improvement over this: border: 1px solid; -moz-border-colors: red; when I really want this to just work: border: 1px solid red;
Assignee | ||
Comment 3•14 years ago
|
||
So one thing that would be quite easy is to make the 'border' shorthand imply -moz-border-*-colors: none, and likewise make border-X imply -moz-border-X-colors: none. It seems like that would help your problem a good bit; not sure how much it would break.
Reporter | ||
Comment 4•14 years ago
|
||
Yeah, that would help, but...
> make border-X imply -moz-border-X-colors: none
what about -moz-border-start/end?
Assignee | ||
Comment 5•14 years ago
|
||
To do that I'd have to implement -moz-border-start-colors and -moz-border-end-colors, I think.
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #3) > and likewise make border-X imply -moz-border-X-colors: none Actually, this part is harder than I thought, thanks to the fun of the parser and the differences between left/right and top/bottom (thanks to start/end).
Assignee | ||
Comment 7•14 years ago
|
||
Here's a patch for making just the 'border' shorthand reset -moz-border-*-colors and (per last week's CSS WG decision) 'border-image'.
Reporter | ||
Comment 8•14 years ago
|
||
(In reply to comment #7) > Created an attachment (id=366883) [details] > patch > > Here's a patch for making just the 'border' shorthand reset > -moz-border-*-colors and (per last week's CSS WG decision) 'border-image'. Can we get this reviewed and landed?
Reporter | ||
Updated•14 years ago
|
Attachment #366883 -
Flags: review?(bzbarsky)
![]() |
||
Comment 9•14 years ago
|
||
I'd sort of like to know whether dbaron thinks the patch is ready to go before reviewing.
Assignee | ||
Comment 10•14 years ago
|
||
Yeah, the patch is fine, but it could use a test.
Assignee | ||
Comment 11•14 years ago
|
||
with test
Assignee: nobody → dbaron
Attachment #366883 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #427596 -
Flags: review?(bzbarsky)
Attachment #366883 -
Flags: review?(bzbarsky)
![]() |
||
Comment 12•14 years ago
|
||
Comment on attachment 427596 [details] [diff] [review] patch r=bzbarsky
Attachment #427596 -
Flags: review?(bzbarsky) → review+
Reporter | ||
Updated•14 years ago
|
Assignee | ||
Comment 13•14 years ago
|
||
I had to make a few additional test changes: http://hg.mozilla.org/users/dbaron_mozilla.com/patches/rev/2b70680896ee
Assignee | ||
Comment 14•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0e7b78eabfd8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment 15•14 years ago
|
||
Does or should this affect serialization at all?
Comment 16•13 years ago
|
||
(In reply to comment #7) > and (per last week's CSS WG decision) 'border-image'. Is there a link to that particular CSS WG discussion/decision available, for reference?
Assignee | ||
Updated•13 years ago
|
Blocks: css3-background
You need to log in
before you can comment on or make changes to this bug.
Description
•