User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:184.108.40.206) Gecko/2009031017 Gentoo Firefox/3.0.7 Build Identifier: xulrunner 220.127.116.11 The old mips o32 ABI patch is not working anymore. Thiemo Seufer made a patch, included in debian's mips firefox. Unfortunately, he passed away 12.26 last year. So I submit this patch for him. I myself made another patch for n32 ABI. This patch should be applied on top of the o32 patch. Reproducible: Always
Is it related to bug 258429's patch? It appears that you patched 1.9.0, and that patch landed for 1.9.1. (Sorry this was ignored, it's best to follow https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch and cc the right people to avoid that.)
Component: General → XPCOM
QA Contact: general → xpcom
Created attachment 429370 [details] [diff] [review] xulrunner-1.9.2_beta4-mips-n32.patch
Attachment #366859 - Attachment is obsolete: true
Attachment #429370 - Attachment description: patch against 1.9.2, works on 1.9.3 too → xulrunner-1.9.2_beta4-mips-n32.patch
o32 patch is already in upstream since 1.9.1.x. so i obsoleted it. also i have updated n32 patch.
(In reply to comment #3) > Is it related to bug 258429's patch? It appears that you patched 1.9.0, and > that patch landed for 1.9.1. bug 258429's patch contains o32 patch which i have made obsoleted.
Comment on attachment 429370 [details] [diff] [review] xulrunner-1.9.2_beta4-mips-n32.patch Benjamin, could you take a look (or suggest someone else), since you reviewed the previous MIPS patch?
Attachment #429370 - Flags: review?(benjamin)
Comment on attachment 429370 [details] [diff] [review] xulrunner-1.9.2_beta4-mips-n32.patch mh, could you look these over? I don't know MIPS at all, and you had bug 547656 which seems related.
Attachment #429370 - Flags: review?(benjamin) → review?(mh+mozilla)
Comment on attachment 429370 [details] [diff] [review] xulrunner-1.9.2_beta4-mips-n32.patch Unfortunately, I know neither mips n32, nor mips assembly. And I don't have access to n32 mips machines either.
Attachment #429370 - Flags: review?(mh+mozilla) → review?
The review has been requested months ago... Any news?
Assignee: nobody → r0bertz
Status: NEW → ASSIGNED
Currently there is no reviewer selected, and I don't know who an appropriate reviewer might be. Perhaps timeless would be willing?
Oups, I've been confused with the review flag assigned to no-one. Let's try timeless then.
Attachment #429370 - Flags: review? → review?(timeless)
i was on vacation last month. i've just reached this request. i'll look when i empty my mailbox (hopefully today).
So, any progress? Thanks!
Comment on attachment 429370 [details] [diff] [review] xulrunner-1.9.2_beta4-mips-n32.patch sorry, this indeed fell beneath my radar (not technically off, just not quite at the top). + * available which coorespond to the first 7 parameters of the correspond +#define PARAM_BUFFER_COUNT 16 +#define PARAM_GPR_COUNT 7 +#define PARAM_FPR_COUNT 7 please don't use tabs in .c/.cpp/.h, they should only be used in makefiles... let's get this landed, very sorry about the delay
Created attachment 497133 [details] [diff] [review] patch for checkin NPOTB ok, this is for a port it should be able to land as NPOTB w/o requiring any approvals. I've addressed my comments.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.