482759 - xulrunner xptcall MIPS patch

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[ZHANG Le]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.7) Gecko/2009031017 Gentoo Firefox/3.0.7
Build Identifier: xulrunner 1.9.0.7

The old mips o32 ABI patch is not working anymore.
Thiemo Seufer made a patch, included in debian's mips firefox.
Unfortunately, he passed away 12.26 last year. So I submit this patch for him.

I myself made another patch for n32 ABI. This patch should be applied on top of the o32 patch.

Reproducible: Always

Comment 1

[ZHANG Le]

Attachment: xulrunner-mips-o32.patch

Comment 2

[ZHANG Le]

Attachment: xulrunner-mips-n32.patch

Comment 3

[Nickolay_Ponomarev]

Is it related to bug 258429's patch? It appears that you patched 1.9.0, and that patch landed for 1.9.1.

(Sorry this was ignored, it's best to follow https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch and cc the right people to avoid that.)

Comment 4

[ZHANG Le]

Attachment: xulrunner-1.9.2_beta4-mips-n32.patch

Comment 5

[ZHANG Le]

o32 patch is already in upstream since 1.9.1.x. so i obsoleted it.
also i have updated n32 patch.

Comment 6

[ZHANG Le]

(In reply to comment #3)
> Is it related to bug 258429's patch? It appears that you patched 1.9.0, and
> that patch landed for 1.9.1.

bug 258429's patch contains o32 patch which i have made obsoleted.

Comment 7

[Nickolay_Ponomarev]

Comment on attachment 429370 [details] [diff] [review]
xulrunner-1.9.2_beta4-mips-n32.patch

Benjamin, could you take a look (or suggest someone else), since you reviewed the previous MIPS patch?

Comment 8

[Benjamin Smedberg]

Comment on attachment 429370 [details] [diff] [review]
xulrunner-1.9.2_beta4-mips-n32.patch

mh, could you look these over? I don't know MIPS at all, and you had bug 547656 which seems related.

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 429370 [details] [diff] [review]
xulrunner-1.9.2_beta4-mips-n32.patch

Unfortunately, I know neither mips n32, nor mips assembly. And I don't have access to n32 mips machines either.

Comment 10

[Mounir Lamouri (:mounir)]

The review has been requested months ago... Any news?

Comment 11

[Benjamin Smedberg]

Currently there is no reviewer selected, and I don't know who an appropriate reviewer might be. Perhaps timeless would be willing?

Comment 12

[Mounir Lamouri (:mounir)]

Oups, I've been confused with the review flag assigned to no-one. Let's try timeless then.

Comment 13

[timeless]

i was on vacation last month. i've just reached this request. i'll look when i empty my mailbox (hopefully today).

Comment 14

[ZHANG Le]

So, any progress? Thanks!

Comment 15

[timeless]

Comment on attachment 429370 [details] [diff] [review]
xulrunner-1.9.2_beta4-mips-n32.patch

sorry, this indeed fell beneath my radar (not technically off, just not quite at the top).


+ * available which coorespond to the first 7 parameters of the

correspond


+#define PARAM_BUFFER_COUNT		16
+#define PARAM_GPR_COUNT			7
+#define PARAM_FPR_COUNT			7

please don't use tabs in .c/.cpp/.h, they should only be used in makefiles...

let's get this landed, very sorry about the delay

Comment 16

[timeless]

Attachment: patch for checkin NPOTB

ok, this is for a port it should be able to land as NPOTB w/o requiring any approvals. I've addressed my comments.

Comment 17

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/269c205a438b