Update Compatibility Dashboard for Firefox 3.5

VERIFIED FIXED in 5.0.4

Status

addons.mozilla.org Graveyard
Compatibility Tools
--
critical
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: fligtar, Assigned: jbalogh)

Tracking

unspecified
5.0.4
Dependency tree / graph

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Since Firefox 3.1 will become Firefox 3.5 and Firefox 3.2 will become Firefox 3.6 (and later something else), we need the ability to make the compatibility dashboard treat two different major/minor versions as the same version.

For all compat dashboard purposes, 3.1 and 3.5 should be considered the same version, such that an add-on compatible with 3.1b2 is considered "beta" compatible with Firefox 3.5, and such that add-ons compatible with Firefox 3.0 are listed in the dashboard, but add-ons compatible with only Firefox 2.0 are not.

The new default report should be 3.5, and 3.1 should probably be removed from the report array in config.php. We'll also need a new graphic for Firefox 3.5 wordmark.

We are expecting that the dashboard will be slightly broken until the 5.0.4 release when this can be pushed.

Updated

9 years ago
Blocks: 482246
(Assignee)

Updated

9 years ago
Depends on: 483700
(Assignee)

Comment 1

9 years ago
Created attachment 369181 [details] [diff] [review]
teaching the compat dashboard to consider multiple versions specs as the same version

NB: We're waiting on an image (bug 483700) so it won't be as pretty as the current dashboard.

A few of the lines are just fixing formatting; the important parts are _versionAlias() and compatibleVersions().

I have this in my config.php:
/**
 * Compatibility Center Versions
 */
define('COMPAT_DEFAULT_VERSION', '3.5');
global $compatibility_versions;
$compatibility_versions = array(
    '3.0', '3.5'
);
// Consider all the mapped versions to be the same as the key.
global $version_aliases;
$version_aliases = array(
    '3.5' => array('3.1', '3.5')
);
Attachment #369181 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #369181 - Flags: review?(fwenzel)
Attachment #369181 - Flags: review?(fligtar)
Attachment #369181 - Flags: review?
(Reporter)

Comment 2

9 years ago
Comment on attachment 369181 [details] [diff] [review]
teaching the compat dashboard to consider multiple versions specs as the same version

Looks good for the most part - a couple concerns:
- I think there may be problems when 2 aliased versions need to compare with each other. By that I mean, I made my alias config like this:

$version_aliases = array(
    '3.5' => array('3.1', '3.5'),
    '3.6' => array('3.2', '3.6')
);

which will be what we do in production, and 3.5 works fine. However, showing the dashboard for 3.6, only 3.6 add-ons show up, when 3.5 add-ons should show up as well as the "previous version"

- Don't really agree with removing the HTML stuff - I run the report script in my browser so that I can look through it more easily, so now it's all jumbled. Can add linebreaks in addition to the HTML though.
Attachment #369181 - Flags: review?(fwenzel)
Attachment #369181 - Flags: review?(fligtar)
Attachment #369181 - Flags: review-
(Reporter)

Comment 3

9 years ago
Comment on attachment 369181 [details] [diff] [review]
teaching the compat dashboard to consider multiple versions specs as the same version

Turns out these things are OK and the dashboard is working properly.
Attachment #369181 - Flags: review- → review+
(Assignee)

Comment 4

9 years ago
r23769 and r23770.

The patch in r23770 needs to be applied to app/config/config.php in production before bin/compatibility_report.php will work.

Leaving this bug open until I can mention the config changes in the push bug.
Keywords: push-needed
(Reporter)

Comment 5

9 years ago
In addition to adding the alias array to the config, we should change 3.1 to 3.5 in the available versions array, and make 3.5 the default.

I would also add 3.6 as an available version.
(Assignee)

Comment 6

9 years ago
Thanks fligtar, r23773.

The full diff for config.php:
diff --git a/site/app/config/config.php.default b/site/app/config/config.php.default
index c9e83e7..60d0f87 100644
--- a/site/app/config/config.php.default
+++ b/site/app/config/config.php.default
@@ -218,10 +218,15 @@ define('RECAPTCHA_PUBLIC_KEY', '...');
 /**
  * Compatibility Center Versions
  */
-define('COMPAT_DEFAULT_VERSION', '3.1');
+define('COMPAT_DEFAULT_VERSION', '3.5');
 global $compatibility_versions;
 $compatibility_versions = array(
-    '3.0', '3.1'
+    '3.0', '3.5', '3.6'
+);
+// Consider all the mapped versions to be the same as the key.
+global $version_aliases;
+$version_aliases = array(
+    '3.5' => array('3.1', '3.5')
 );

 ?>
(Assignee)

Comment 7

9 years ago
Wil noted the changes to config.php in bug 487217, so I'm calling it on this one.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
This is up on preview at https://preview.addons.mozilla.org/en-US/firefox/compatibility/, for those who want to test.

Not sure if this (yet) uses production data, though?
(Assignee)

Comment 9

9 years ago
I'm seeing a big white box on the end (instead of green), due to rounding weirdness.  The widths add up to 100.01421999999999, so there's overflow which pushes the last box down the page.
(In reply to comment #9)
> I'm seeing a big white box on the end (instead of green), due to rounding
> weirdness.  The widths add up to 100.01421999999999, so there's overflow which
> pushes the last box down the page.

I filed bug 487526 for that.
(Data also matches the appversions listed here: https://preview.addons.mozilla.org/en-US/firefox/pages/appversions, so that's good.)

Should I verify this as fixed, or wait until bug 487526 gets fixed (and set it as a dependency)?
Keywords: push-needed
(Reporter)

Updated

9 years ago
Component: Public Pages → Compatibility Tools
QA Contact: web-ui → compatibility
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.