483370 - Buttons on Security tab are broken when windows are already open

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect, P2)

Description

[Krang]

On the Security tab of Page Info, the "View Cookies" and "View Saved Passwords" buttons do not work if the Cookie Manager and the Password Manager are already open.  This appears to be a regression from bug 449661 and bug 449664, which removed the setFilter() functions that are used in security.js.  This has been tested using the latest 3.1/3.5 nightly on WinXP:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090313 Shiretoko/3.1b4pre

Comment 1

[Steffen Wilberg]

I could take care of this as well.

Comment 2

[Dão Gottwald [:dao]]

Thanks, I already have the patch.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

I forgot to also use setFilter in cookies.js, to avoid code duplication.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 367395 [details] [diff] [review]
patch v2

I don't think we needed to change all of the whitespace around, but if you're dropping the curly braces it'd mess up blame anyway.

>-function _filterPasswords()
>-{
>+function _filterPasswords() {

leave this change out, you're just messing with blame.

r=me with that.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/83f0470b40fa
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8be577118922

Comment 8

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090318 Shiretoko/3.5b4pre and the latest Vista nightly. Adding keyword.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on trunk too with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090318 Minefield/3.6a1pre ID:20090318030831

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090318 Minefield/3.6a1pre ID:20090318052249