use the new search textbox binding in the cookie viewer

VERIFIED FIXED in Firefox 3.1b1

Status

()

Firefox
Preferences
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

Trunk
Firefox 3.1b1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 332801 [details] [diff] [review]
patch
(Assignee)

Updated

10 years ago
Summary: use the new searchbox in the cookie viewer → use the new search textbox binding in the cookie viewer

Comment 1

10 years ago
This is very similar to bug 449661.

gCookiesWindow.clearFilter cleanup is missing from the patch:
* no need to set value = ""
* no need to focus the filter textbox
(Assignee)

Comment 2

10 years ago
Yeah, I was already comparing the patches...
I also inlined setFilter() like you did.
(Assignee)

Comment 3

10 years ago
Created attachment 332804 [details] [diff] [review]
patch

I didn't re-indent filter() yet.
Attachment #332801 - Attachment is obsolete: true
Attachment #332804 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #332804 - Flags: review? → review?(mano)

Updated

10 years ago
Blocks: 449045

Updated

10 years ago
No longer blocks: 449045
(Assignee)

Updated

10 years ago
Flags: wanted-firefox3.1?
Status: NEW → ASSIGNED
Whiteboard: [has patch][needs review mano]

Updated

10 years ago
Keywords: checkin-needed
Whiteboard: [has patch][needs review mano]

Comment 5

10 years ago
http://hg.mozilla.org/mozilla-central/rev/38769ea4a583
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
(Assignee)

Comment 6

10 years ago
Thanks, especially for getting the review.
I usually like to push my stuff myself though. I just re-indented filter(): http://hg.mozilla.org/mozilla-central/rev/ee45b152b256.
Flags: wanted-firefox3.1?
Verified with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080927033433 Minefield/3.1b1pre ID:20080927033433

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080927020752 Minefield/3.1b1pre ID:20080927020752
Status: RESOLVED → VERIFIED

Updated

9 years ago
Depends on: 483370
You need to log in before you can comment on or make changes to this bug.