Closed
Bug 449664
Opened 16 years ago
Closed 16 years ago
use the new search textbox binding in the cookie viewer
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 3.1b1
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.70 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•16 years ago
|
Summary: use the new searchbox in the cookie viewer → use the new search textbox binding in the cookie viewer
|
||
Comment 1•16 years ago
|
||
This is very similar to bug 449661.
gCookiesWindow.clearFilter cleanup is missing from the patch:
* no need to set value = ""
* no need to focus the filter textbox
|
|
Assignee | |
Comment 2•16 years ago
|
||
Yeah, I was already comparing the patches...
I also inlined setFilter() like you did.
|
|
Assignee | |
Comment 3•16 years ago
|
||
I didn't re-indent filter() yet.
Attachment #332801 -
Attachment is obsolete: true
Attachment #332804 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #332804 -
Flags: review? → review?(mano)
|
|
Assignee | |
Updated•16 years ago
|
Flags: wanted-firefox3.1?
|
||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [has patch][needs review mano]
|
||
Comment 4•16 years ago
|
||
Comment on attachment 332804 [details] [diff] [review]
patch
r=mano
Attachment #332804 -
Flags: review?(mano) → review+
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch][needs review mano]
|
|
||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
|
|
Assignee | |
Comment 6•16 years ago
|
||
Thanks, especially for getting the review.
I usually like to push my stuff myself though. I just re-indented filter(): http://hg.mozilla.org/mozilla-central/rev/ee45b152b256.
Flags: wanted-firefox3.1?
|
|
||
Comment 7•16 years ago
|
||
Verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080927033433 Minefield/3.1b1pre ID:20080927033433
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080927020752 Minefield/3.1b1pre ID:20080927020752
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•