483465 - I'm looking forward to become a gecko developer

Status: RESOLVED INVALID

(mozilla.org :: Repository Account Requests, task)

Description

[huang li]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/530.0 (KHTML, like Gecko) Chrome/2.0.160.0 Safari/530.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; zh-CN; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 (.NET CLR 3.5.30729)

We are using mozilla tech to develop a desktop integration environment

Reproducible: Always

Comment 1

[:Gavin Sharp [email: [e-mail]]]

It's not clear what your intention was in filing this bug. You don't need an HG account to contribute patches to Gecko.

If you are looking to obtain commit access, you should make sure you meet the criteria defined at http://www.mozilla.org/hacking/committer/ .

Comment 2

[huang li]

Hi gavin,
Before file the bug, I have readed http://www.mozilla.org/hacking/committer/ very carefully.If my understanding is right, You must be my first voucher.So, could you please add a comments that say you are vouching, thanks a lot.
In bug #483148, I have committed a patch that can fix several problem.

(In reply to comment #1)
> It's not clear what your intention was in filing this bug. You don't need an HG
> account to contribute patches to Gecko.
> 
> If you are looking to obtain commit access, you should make sure you meet the
> criteria defined at http://www.mozilla.org/hacking/committer/ .

Comment 3

[huang li]

I readed http://www.mozilla.org/hacking/committer/ again, I find I have not committed enough good size patchs for mozilla.It doesn't matter, my work is that
use mozilla tech to create a desktop work integration environment(DWIE).
Because gecko first was designed for browser rather than normal rich client application.We have use XUL and js to develop a primary DWIE that also contain some special application, e.g IM(instant message), Address Book, DWIE sidebar application.When we developed IM, IM's latter chat window always grab in use chat window focus or in use other DWIE application window focus.For fix this problem and don't affect current chrome feature code branch,I add "noactivate" for window.open feature parameter, bug #483148 patch contain the changes.
when we place <panel> in DWIE sidebar, that <panel> depend on a <iframe> src to archive a web weather that contain some <select>，we find <select> can't popup。In widget code, I find root cause is 5 static global variables, if fix frame or view in layout, it will affect more things. For minimize the problem, in widget code , I add a static global variable, after apply my change , first click the <select> will not popup combobox list, by reason that release <panel> resource that the 5 static global refer to. the changes was contained by bug #483148  patch.
For fix bad z-order that dependent window and alwaysraised window coexist, I change code to skip over the z-order arithmetic , and because alwaysraised wasn't topmost, so I change code that when alwaysraised was passed as feature parameter, created window type become eWindow_type_raise that is topmost window.the changes was contained by bug #483148  patch.
In linux, I find dependent window has taskbar reference and border, so I add also a new window type eWindow_type_dependent_dialog that has not taskbar reference and is borderless.the changes was contained by bug #483148  patch.

I think my Current work encounter these problem is very simple, because these are only a very small step in our goal.DWIE will be very challenge , so we'll encounter more flinty trial in future. 

mozilla is very excellent technology , gecko render engine is so fast. for we can use newest gecko feature and can let DWIE work normally, we need merge our changes into hg in time.we believe that will be a reciprocal process.

(In reply to comment #2)
> Hi gavin,
> Before file the bug, I have readed http://www.mozilla.org/hacking/committer/
> very carefully.If my understanding is right, You must be my first voucher.So,
> could you please add a comments that say you are vouching, thanks a lot.
> In bug #483148, I have committed a patch that can fix several problem.
> 
> (In reply to comment #1)
> > It's not clear what your intention was in filing this bug. You don't need an HG
> > account to contribute patches to Gecko.
> > 
> > If you are looking to obtain commit access, you should make sure you meet the
> > criteria defined at http://www.mozilla.org/hacking/committer/ .

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Looks like there was a misunderstanding here... People usually aren't given commit access after having written a single patch. I encourage you to read https://developer.mozilla.org/en/Getting_your_patch_in_the_tree and follow that process to have your patches integrated.

Comment 5

[huang li]

(In reply to comment #4)
> Looks like there was a misunderstanding here... People usually aren't given
> commit access after having written a single patch. I encourage you to read
> https://developer.mozilla.org/en/Getting_your_patch_in_the_tree and follow that
> process to have your patches integrated.

I got it. thanks for Gavin.