Trailing <br> node not removed when it should be

RESOLVED FIXED in mozilla8

Status

()

Core
Editor
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: graememcc, Assigned: graememcc)

Tracking

(Depends on: 1 bug)

Trunk
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
When bug 132133, it ensured that the last node in non-empty non-single-line editors would be a <br> node. However, it proves very persistent - when all other content is removed from the tree, and it no longer serves any purpose, it should go away, and the special "bogus node" should reappear. Instead it sticks around.

Consequences of this include:
- documentIsEmpty reporting the wrong value
- deleting text in a <textarea> by a) manually backspacing through the text and b) select all followed by cut lead to different DOM trees
(Assignee)

Comment 1

8 years ago
Created attachment 367636 [details] [diff] [review]
Patch

Proposed fix
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
Attachment #367636 - Flags: superreview?(peterv)
Attachment #367636 - Flags: review?(peterv)
Depends on: 503838

Updated

6 years ago
Attachment #367636 - Flags: review?(ehsan)
Created attachment 552737 [details] [diff] [review]
Updated patch

The patch looked good, I just updated it to apply cleanly on trunk.  I'll land it on mozilla-inbound.
Attachment #367636 - Attachment is obsolete: true
Attachment #552737 - Flags: review+
Attachment #367636 - Flags: superreview?(peterv)
Attachment #367636 - Flags: review?(peterv)
Attachment #367636 - Flags: review?(ehsan)
http://hg.mozilla.org/mozilla-central/rev/437f3eb67c18
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla8

Updated

5 years ago
Depends on: 740784
You need to log in before you can comment on or make changes to this bug.