Closed
Bug 483856
Opened 15 years ago
Closed 15 years ago
Use $(CURDIR) to make pymake happy
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
8.40 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
A little minor cleanup to make Windows absolute $(srcdir) paths work with pymake: use $(CURDUR) and core_abspath, as well as using Preprocessor.py instead of preprocessor.pl.
Attachment #367838 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Attachment #367838 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 1•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/530404879896
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 2•15 years ago
|
||
Bug 483062 uses $(CURDIR). Any reason not to land this bug on m-1.9.1?
Blocks: 483062
status1.9.1:
--- → ?
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment 3•15 years ago
|
||
$(CURDIR) is a built-in make variable. You shouldn't need this patch on 1.9.1 to land that patch.
Comment 4•15 years ago
|
||
k. Can it land anyway, wrt config.mk "core_abspath = ..."? (See bug 474703 comment 18...)
Comment 5•15 years ago
|
||
Why? We don't need to support pymake on 1.9.1, and this isn't blocking anything else, AFAICT. If it blocks something you really do want to land on the branch, then fine. But if not, then it doesn't seem worth it.
Updated•15 years ago
|
No longer blocks: 474703
status1.9.1:
? → ---
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•