Port |Bug 483856 - Use $(CURDIR) to make pymake happy| to comm-central

RESOLVED FIXED in Thunderbird 3.1b2

Status

defect
--
trivial
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: kairo, Assigned: sgautherie)

Tracking

Trunk
Thunderbird 3.1b2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

10 years ago
As mentioned in bug 509095, it's OK to wallpaper over the lack of core_abspath in comm-central config.mk as long as our mainline is based on 1.9.1, but in the long run we probably want to do things right and port bug 483856 to comm-central (after we branch).
Assignee

Updated

10 years ago
Blocks: C192ConfSync
Severity: normal → trivial
Depends on: 483856, 522211, 509095
Flags: in-testsuite-
Target Milestone: Future → ---
Depends on: 545085
Assignee

Updated

10 years ago
Summary: Port bug 483856 to comm-central → Port |Bug 483856 - Use $(CURDIR) to make pymake happy| to comm-central
Assignee

Updated

10 years ago
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Depends on: 521523, 533043, 463605
Target Milestone: --- → Thunderbird 3.1b1
Assignee

Comment 1

10 years ago
*Copy bug 483856 itself.
 *PP_LOCALIZED_FILES part: was removed by TB bug 533043 and SM bug 521523.
*core_abspath: undo TB bug 509095, SM+TB changeset a09a7d1c82d7 (bug 463605) and part of SB changeset b9ea76f33831.
Attachment #426993 - Flags: review?(bugzilla)
Comment on attachment 426993 [details] [diff] [review]
(Av1) Just copy it, Remove previous c-c workaround(s)

I did review all parts; but I'm not technically a mail/ or a calendar/ reviewer so leaving mark's request open.
Attachment #426993 - Flags: review+
Comment on attachment 426993 [details] [diff] [review]
(Av1) Just copy it, Remove previous c-c workaround(s)

This either needs a refresh or this is fixed now.
Attachment #426993 - Flags: review?(bugzilla)
Assignee

Comment 4

9 years ago
What's left of patch Av1 after bug 545085 :-/
Attachment #426993 - Attachment is obsolete: true
Attachment #431064 - Flags: review?(bugzilla)
Comment on attachment 431064 [details] [diff] [review]
(Av2) Just copy it
[Checkin: See comment 6]

>diff --git a/mail/base/Makefile.in b/mail/base/Makefile.in
>--- a/mail/base/Makefile.in
>+++ b/mail/base/Makefile.in
>@@ -68,9 +68,8 @@ endif
...
> include $(topsrcdir)/config/rules.mk
>-

Please drop this change, its unnecessary here.

r=Standard8 without that.
Attachment #431064 - Flags: review?(bugzilla) → review+
Assignee

Comment 6

9 years ago
Comment on attachment 431064 [details] [diff] [review]
(Av2) Just copy it
[Checkin: See comment 6]


http://hg.mozilla.org/comm-central/rev/7353fbf8aafe
Av2, with comment 5 suggestion(s).
Attachment #431064 - Attachment description: (Av2) Just copy it → (Av2) Just copy it [Checkin: See comment 6]
Assignee

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.1b1 → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.