483906 - Category recommended add-ons are not labeled

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Dave Garrett]

From bug 437150 comment 49, 50. See bug 437150 comment 32 - 41.

All "recommended" add-ons should have the recommended label (or icon, if we go back to that). Currently just featured (front page recommended) add-ons do and not also the category-recommended add-ons. These need the label too.

See also bug 483664. The current title of that one is interesting, because currently there is no "featured" label, just "recommended". Nick, did I miss something somewhere saying this was to be added? If that was or is now intended then someone would need to add the "featured" label for the recommendeds and change the "recommended" label to be for the category-recommendeds. However, I thought a result of the discussion in bug 437150 at some point was that this distinction was overly confusing and didn't need to be exposed to users?

One way or another, it seems these were intended to be labeled in some way. Ryan, you were looking into just making is_recommended() find category-recommendeds. Did you decide anything with that?

Comment 1

[Nick Nguyen [:osunick]]

Agreed- I thought CR add-ons were labeled but I was mistaken.  We should have 'recommended' as a label for both reco'd and CR add-ons.

Comment 3

[Ryan Doherty (:rdoherty)]

Attachment: Fix (with test)

Patch with test. I couldn't get the test to connect to my db, advice appreciated.

Comment 4

[Dave Garrett]

You might want to add something to the comments or use a word other than "featured". Those currently shown as "recommended" are called "featured" and those with the "featured" tag are the "category-recommended" ones. (I get confused just trying to follow this; who named this stuff?...)

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: patch with working tests!

Comment 6

[Ryan Doherty (:rdoherty)]

Comment on attachment 374292 [details] [diff] [review]
patch with working tests!

Spinning the review dice. Let me know if I should pass it on to someone else.

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 374292 [details] [diff] [review]
patch with working tests!

You know when the review dice come up clouserw you're in for a good time.

Comment 8

[Ryan Doherty (:rdoherty)]

r24792

Comment 9

[Wil Clouser [:clouserw]]

One side effect of this that might be misleading is that add-ons are highlighted "recommended" no matter what category they are in.  So, if an add-on is recommended for web development but someone is browsing the appearance category it will still be flagged as recommended.

I'm not saying we should change the patch but something we should consider.  And by we I mean nick. :)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

All category-recommended add-ons on https://preview.addons.mozilla.org/en-US/firefox/recommended/cat:72 and the like have the "Recommended" label, for me; Dave, can you confirm that this is fixed too?

(Not sure what to do about Wil's comment 9.)

Comment 11

[Dave Garrett]

Recommended labels show for category-recommendeds on recommended list, sorted lists, and in a returned search list. Looks good to me.

As to comment 9, it sort of makes sense to label multi-category add-ons recommended in all category lists. We're recommending the add-on not the category. The specific category it's listed for will just determine which category landing page it may show on, then. We could probably add a tooltip or something to the label saying "recommended <category> add-on", but I don't think it's that critical.