483914 - middle-mouse paste fails if the input value is cleared on focus

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect)

Description

[Karl Tomlinson (:karlt)]

STR:

1. Open a new window and, if necessary, erase any contents of the location bar.

2. Put some text into the X selection. (e.g. select some text somewhere.)

3. Click on the search bar to move focus away from the location bar.
   "Search Bookmarks and History" is shown in the location bar.

4. Try to paste into the location bar.

5. If paste was successful then delete the pasted text and repeat from 3,
   leaving a couple of seconds before 4.

6. If paste was not successful then repeat 3 and 4 quickly until paste succeeds.

Expected results after 4:
Location bar receives focus and displays pasted text.  This is what happens with most text input boxes and is what happened with the location bar in Firefox 3.0.

Actual results:
Location bar only receives focus.

This is a regression for the location bar, but Firefox 3 had the same bug with the search bar, which makes me suspect something to do with the "Search Bookmarks and History" text and perhaps the order of processing events to remove this text.

Comment 1

[Elmar Ludwig]

Looks like pasting the selection over the emptyText ("Search Bookmarks and History", "Google" etc.) fails. This also affects other input fields that use emptyText, like searching add-ons and downloads.

Comment 2

[Marco Bonardo [:mak]]

Dao could know something about this, he worked recently on emptytext iirc

Comment 3

[Dão Gottwald [:dao]]

t and

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> t and

Interesting. I guess I pasted something accidentally...

Comment 5

[Dão Gottwald [:dao]]

Testcase:
data:text/html,<input onfocus="this.value=''" value="xxxxxxxxxx">

If you paste with the mouse over the text, it fails. It works if you paste with the mouse after the text, over the empty area.

Comment 6

[Dão Gottwald [:dao]]

Also happens on Windows with middlemouse.paste set to true.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P4 - Polish issue that is rarely encountered, and is easily identifiable.

Easy to notice when it happens, but sounds like it is rare and the only effected user segment is people who actively use the X selection.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I was doing some debugging on this.  Didn't learn too much but I don't think the problem is in libeditor.  When the paste fails the middlemouse event never gets close to nsTextEditorMouseListener::MouseClick.  I'm going to keep messing with it in my spare time and see if I can get anywhere.

Comment 9

[Elmar Ludwig]

This seems to WFM now in a current Linux trunk build, though I don't know why.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a2pre) Gecko/20100227 Minefield/3.7a2pre ID:20100227031019

Comment 10

[Karl Tomlinson (:karlt)]

Yes, WFM with 11c913d25658.  Thanks!

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This would probably be worth writing unit tests for to make sure it doesn't magically stop working.  Assigning to myself but feel free to steal if you have time.