484386 - TEST_PATH ignored on "make mochitest-browser-chrome"

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Robert Kaiser]

When trying to call any

TEST_PATH=../browser/foo/bar make mochitest-browser-chrome

the path is completely ignored and all tests are run.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> When trying to call any
> 
> TEST_PATH=../browser/foo/bar make mochitest-browser-chrome

The TEST_PATH argument is relative to the source directory, not the current directory, so the ../ is unnecessary.

TEST_PATH=browser/base/content make mochitest-browser-chrome

works for me on Mac and Linux:

Comment 2

[Robert Kaiser]

Hmm, interesting, seems to work in Minefield her but not in SeaMonkey. So, either this is a bug that is fixed in 1.9.2 but not 1.9.1 or it is in SeaMonkey's invocation. Unfortunately, I don't have a Shiretoko tree around here atm.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Oh, you have your own target in suite/build.mk, and it just hasn't had the patch from bug 454320 applied (or the followup from bug 474191).

Comment 4

[Robert Kaiser]

Attachment: handle TEST_PATH in suite/build.mk

This is a straight port of the bugs gavin has mentioned (thanks for that), and with it applied, I could easily use the following to only test the bug 484188 tests in my tree:

TEST_PATH=suite/browser/ make mochitest-browser-chrome

Comment 5

[[e-mail]]

Comment on attachment 368703 [details] [diff] [review]
handle TEST_PATH in suite/build.mk

>+else
>+BROWSER_TEST_PATH =
I don't know about you but this bit looks unnecessary to me...

Comment 6

[Robert Kaiser]

(In reply to comment #5)
> (From update of attachment 368703 [details] [diff] [review])
> >+else
> >+BROWSER_TEST_PATH =
> I don't know about you but this bit looks unnecessary to me...

I thought about it and I prefer to have it there just to clearly point out the var we use is actually empty in that case.

Pushed as http://hg.mozilla.org/comm-central/rev/573fb4c0ec8b