Closed Bug 484386 Opened 11 years ago Closed 11 years ago

TEST_PATH ignored on "make mochitest-browser-chrome"

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

When trying to call any

TEST_PATH=../browser/foo/bar make mochitest-browser-chrome

the path is completely ignored and all tests are run.
Summary: TEST_PATH ignored on "make mochitest-borwser-chrome" → TEST_PATH ignored on "make mochitest-browser-chrome"
(In reply to comment #0)
> When trying to call any
> 
> TEST_PATH=../browser/foo/bar make mochitest-browser-chrome

The TEST_PATH argument is relative to the source directory, not the current directory, so the ../ is unnecessary.

TEST_PATH=browser/base/content make mochitest-browser-chrome

works for me on Mac and Linux:
Hmm, interesting, seems to work in Minefield her but not in SeaMonkey. So, either this is a bug that is fixed in 1.9.2 but not 1.9.1 or it is in SeaMonkey's invocation. Unfortunately, I don't have a Shiretoko tree around here atm.
Oh, you have your own target in suite/build.mk, and it just hasn't had the patch from bug 454320 applied (or the followup from bug 474191).
Assignee: nobody → build-config
Component: BrowserTest → Build Config
Product: Testing → SeaMonkey
QA Contact: browsertest → build-config
This is a straight port of the bugs gavin has mentioned (thanks for that), and with it applied, I could easily use the following to only test the bug 484188 tests in my tree:

TEST_PATH=suite/browser/ make mochitest-browser-chrome
Assignee: build-config → kairo
Status: NEW → ASSIGNED
Attachment #368703 - Flags: review?(neil)
Comment on attachment 368703 [details] [diff] [review]
handle TEST_PATH in suite/build.mk

>+else
>+BROWSER_TEST_PATH =
I don't know about you but this bit looks unnecessary to me...
Attachment #368703 - Flags: review?(neil) → review+
(In reply to comment #5)
> (From update of attachment 368703 [details] [diff] [review])
> >+else
> >+BROWSER_TEST_PATH =
> I don't know about you but this bit looks unnecessary to me...

I thought about it and I prefer to have it there just to clearly point out the var we use is actually empty in that case.

Pushed as http://hg.mozilla.org/comm-central/rev/573fb4c0ec8b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 469581
Depends on: 454320, 474191
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → seamonkey2.0b1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.