484468 - GetMessageTime() needs to be implemented

Status: RESOLVED WONTFIX

(Core :: Widget: Win32, defect)

Description

[Doug Turner (:dougt)]

Currently GetMessageTime just returns zero on windows mobile.  This value is important for mouse events (it is set as the time attribute).

Comment 1

[Doug Turner (:dougt)]

Attachment: gettimecount simulation

good enough simulation of GetMessageTime for the usage in nsWindow.cpp.

Comment 2

[Doug Turner (:dougt)]

Attachment: gettimecount simulation

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 368597 [details] [diff] [review]
gettimecount simulation

This isn't quite the behavior that is expected from GetMessageTime().  It seems we could get the actual time of the message from MSG.time. Could you look at doing that?

Comment 4

[Doug Turner (:dougt)]

that is why i called it a simulation.  the alternative, as I mentioned in IRC, is to overload PeekMessage and GetMessage (using the shunt), record the time, then return that.  However, since GetMessageTime is only used in this file, and it is only used to set the right time on the mouseevents that we are creating (which we create when we get the WM_ event), I proposed that we just simulate the time.

Comment 5

[Doug Turner (:dougt)]

we might be able to just above GetMessageTime() all together and use something that gives us access to the event.  looking....

Comment 6

[Doug Turner (:dougt)]

GetMessage and PeekMessage are called in a few different places.  We could plumb the MSG pointer from the Get/Peek Message callsite to where GetMessageTime() is called.  Or we can overload both APIs in our shunt and remember the message time.

I am not convinced that it matters really since the event time will just be uniformly increased.  And this is much better than what we have.

I am open to other suggestions.

Comment 7

[Doug Turner (:dougt)]

vlad, do you have an opinion here?

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

We have the time in nsAppShell::ProcessNextNativeEvent because we have the MSG there, right?  So just stick the time in a global (or a static element on nsAppShell), and access it from nsWindow.  Could just get rid of GetMessageTime calls altogether and use that approach cross-platform.

Comment 9

[Justin Dolske [:Dolske]]

Worked around this in bug 507064.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Doug, can we close this out?

Comment 11

[Doug Turner (:dougt)]

why would we not just want to fix this and remove the workaround that dolske added?

Comment 12

[Ed Morley [:emorley]]

WinCE/Windows Mobile support has been removed from the main build system, Spidermonkey, mobile installer, in-app updater and so on (see bug 614720, bug 554087 and all their dependants). Until such point where MS decide to release a Windows Phone 7 NDK and the decision is made to port to that platform, this is WONTFIX.

Filter bugmail on WinCEMassWONTFIX.