485031 - WinCE Crash on First Startup (or command line environment passing)

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Doug Turner (:dougt)]

On first run, a dialog is presented saying "a problem has occured with xulrunner.exe" due to xulrunner crashing.

It crashes after xulrunner creates the profile directory, extensions, and other directories.

Comment 1

[kantha kanchiraju]

Attachment: dump files from omnia

I was able to reproduce the error on omnia.

Comment 2

[kantha kanchiraju]

Additional info for comment #1

The build I made is based on the following changeset

changeset:   26816:1a6d30255368
tag:         tip
user:        Simon Montagu <[e-mail]>
date:        Wed Apr 01 06:56:13 2009 -0700
summary:     Remove duplicate property added in bug 437276, rs=Neil

It is a optimized build. Produced with 
Visual Studio 9 and windows mobile 6 sdk.

jemalloc was enabled in the build.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix crash

Use delete instead of free.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

And the patch also fixes another issue in ExtractEnvironmentFromCL that the arguments are overkilled.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

To reproduce this crash easily, use --environ:"SOMETHING=something" option for xulrunner.exe.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 371796 [details] [diff] [review]
Fix crash

switching the review to bsmedberg

Comment 7

[Benjamin Smedberg]

Comment on attachment 371796 [details] [diff] [review]
Fix crash

Boy, rewriting argv like that sucks, but short of making a copy I guess that's the best we can do.

Comment 8

[John Wolfe (:wolfe)]

This patch fixes the first startup crashing for me.

This patch also fixes the "--environ=EM_NO_RESTART=1" crashing for me.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Attachment: Update patch

Modified copied arguments.

Benjamin, could you please review this patch again?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 372017 [details] [diff] [review]
Update patch

>diff -r 3051d82cb64f toolkit/xre/nsWindowsWMain.cpp

>-  for (int i=0; i<argc; i++)
>+  for (int i=0; i< argc; i++)
>     deleteUs[i] = argvConverted[i];

If you want to change this, put spaces between the "=" and the "<" to match the prevailing style. If you didn't mean to change it, undo this single space change.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Attachment: Revised patch [Checkin: Comment 12 & 14]

Put some spaces.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/ee6b9bf4c378

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 372039 [details] [diff] [review]
Revised patch
[Checkin: Comment 12 & 14]

a191=beltzner

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 372039 [details] [diff] [review]
Revised patch
[Checkin: Comment 12 & 14]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9bec603454c2