Use gmake to build NSS, even when using pymake everywhere else

RESOLVED FIXED in mozilla1.9.2a1

Status

defect
RESOLVED FIXED
10 years ago
Last year

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

Trunk
mozilla1.9.2a1
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

10 years ago
Building NSS with pymake on Windows is almost impossible because it mixes Windows-style paths and Unix-style paths very poorly. So rather than deal with the rats nest, I'm just bailing and building NSS with gmake.

We can revisit later if appropriate.

This also moves make version and flavor checks into the root Makefile instead of putting them in configure.
Attachment #369554 - Flags: review?(ted.mielczarek)
Assignee

Updated

10 years ago
Blocks: 485412
Comment on attachment 369554 [details] [diff] [review]
Build NSS with gmake always, rev. 1
[Checkin: Comment 2]

I don't really like this patch, but I don't want to block on fixing NSS' build system, either. Can you file a followup on fixing NSS to work properly with pymake?
Attachment #369554 - Flags: review?(ted.mielczarek) → review+
Assignee

Updated

10 years ago
Blocks: 486141
Assignee

Comment 2

10 years ago
http://hg.mozilla.org/mozilla-central/rev/29c9518a29af

Which unfortunately didn't have a bug# in the commit comment. Filed bug 486141 for NSS followup.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: C192ConfSync
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment on attachment 369554 [details] [diff] [review]
Build NSS with gmake always, rev. 1
[Checkin: Comment 2]

>diff --git a/configure.in b/configure.in
> dnl Be sure the make we use is GNU make.
> dnl on win32, gmake.exe is the generally the wrong version

It looks like this comment should be removed from this file too.
Port it as in bug 513709 ;-)
Attachment #427020 - Flags: review?(bugspam.Callek)
Comment on attachment 427020 [details] [diff] [review]
(Bv1-CC) Remove all these from comm-central

You're right in that c-c doesn't need the gmake part of this. Put please port the Makefile.in change: (including wrapping in |ifndef .PYMAKE| like the actual checkin did)
Attachment #427020 - Flags: review?(bugspam.Callek) → review-
Attachment #369554 - Attachment description: Build NSS with gmake always, rev. 1 → Build NSS with gmake always, rev. 1 [Checkin: Comment 2]
Bv1-CC, with comment 5 suggestion(s).

I thought the m-c check might be enough, but no problem adding it on c-c too.
Attachment #427020 - Attachment is obsolete: true
Attachment #427058 - Flags: review?(bugspam.Callek)
Attachment #427058 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 427058 [details] [diff] [review]
(Bv2-CC) On comm-central, Copy the useful part of this, Remove the rest
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/ce2c7c200aa9
Attachment #427058 - Attachment description: (Bv2-CC) On comm-central, Copy the useful part of this, Remove the rest → (Bv2-CC) On comm-central, Copy the useful part of this, Remove the rest [Checkin: Comment 7]
Depends on: 480069, 492026
Comment on attachment 427058 [details] [diff] [review]
(Bv2-CC) On comm-central, Copy the useful part of this, Remove the rest
[Checkin: Comment 7]

(In reply to Bug 492026 comment #14)
> {
> make[2]: MAKE@: Command not found
> make[2]: *** [default] Error 127
> }
> 
> http://hg.mozilla.org/comm-central/rev/b80103b363ea
> (Bv1) configure.in: restore 'AC_PATH_PROGS(MAKE, ...' removed too soon by bug
> 485405.

Hmm actually though the bustage fix you checked in works, its the incorrect fix.

The problem was with this actual patch, (and sorry for not catching the problem).

Just remove the autoconf.in MAKE = @MAKE@ stuff. the error is because the build system expanded $(MAKE) to "@MAKE@" the first @ is interpreted as an "ignore errors on this line" and then it tries to execute a program called "MAKE@" which it doesn't find.

So feel free to backout that changeset along with the removal of MAKE in the autoconf.in with rs=me.
Attachment #427232 - Flags: review?(ted.mielczarek) → review+
(In reply to comment #10)

Replied on bug 492026!
Comment on attachment 427232 [details] [diff] [review]
(Cv1) Remove leftover comment on (1.9.3) m-c
[Checkin: Comment 12]


http://hg.mozilla.org/mozilla-central/rev/ecf773a4b36f
Attachment #427232 - Attachment description: (Cv1) Remove leftover comment on (1.9.3) m-c → (Cv1) Remove leftover comment on (1.9.3) m-c [Checkin: Comment 12]

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.