Port |Bug 480069 - Recursive submakes without shell loops| to comm-central

RESOLVED FIXED in Thunderbird 3.1b2

Status

defect
--
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Depends on 1 bug)

Trunk
Thunderbird 3.1b2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

10 years ago
Bug 480069 has 'wanted1.9.1-'.

I guess comm-central will want to (im)port that bug,
but I don't know if we should '#ifdef 1.9.1' yet or wait until comm-central branches?
If its not hurting us in terms of being able to get things done and keep trunk running, then we can wait.
Assignee

Updated

10 years ago
No longer blocks: CcMcBuildIssues
Depends on: CcMcBuildIssues
Assignee

Comment 2

10 years ago
Posted patch (Av1) Just copy it (obsolete) — Splinter Review
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #420036 - Flags: review?(bugspam.Callek)
Assignee

Updated

10 years ago
Depends on: 537880
Comment on attachment 420036 [details] [diff] [review]
(Av1) Just copy it

r+ assuming this works on at least trunk ++ 1.9.2 [on at least 1 tested platform] still.

Did not test locally. Does look correct based on ported bug's changeset.
Attachment #420036 - Flags: review?(bugspam.Callek) → review+
Assignee

Comment 4

10 years ago
http://build.mozillamessaging.com/buildbot/try/changes/294
{
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1262686294.1262690699.28127.gz&fulltext=1
Try server comm-central mac hg builder on 2010/01/05 02:11:34

Undefined symbols:
  "CrashReporter::SetServerURL(nsACString_internal const&)", referenced from:
[...]
ld: symbol(s) not found
collect2: ld returned 1 exit status
}

Trying a 2nd time...
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.1a1
Assignee

Comment 5

10 years ago
(In reply to comment #4)

http://build.mozillamessaging.com/buildbot/try/changes/295:
same error.
Mark, would you have a clue? (some wrong/missing dependency or something?)
Comment on attachment 420036 [details] [diff] [review]
(Av1) Just copy it

Serge, given your issues with try, lets have Mark sr+ this before you check in.
Attachment #420036 - Flags: superreview?(bugzilla)
Assignee

Comment 7

10 years ago
(In reply to comment #4)
> http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1262686294.1262690699.28127.gz&fulltext=1
> Try server comm-central mac hg builder on 2010/01/05 02:11:34

This build had bug 538090 !
This patch should pass now: let's try...
Depends on: 538090
Flags: blocking-thunderbird3.1?
Why should this block 3.1? There's nothing here that is affecting functions is there?
Assignee

Comment 9

10 years ago
(In reply to comment #8)
> Why should this block 3.1?

Sorry, I didn't mean to set that flag.
Flags: blocking-thunderbird3.1?
Assignee

Comment 10

10 years ago
(In reply to comment #7)
> This build had bug 538090 !
> This patch should pass now: let's try...

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1262770830.1262777187.5399.gz&fulltext=1
Try server comm-central mac hg builder on 2010/01/06 01:40:30
Bug 538090 is fixed, but this patch still fails :-(

To be explicit, the only hint here is that it's MacOSX specific...
Keywords: helpwanted
Assignee

Updated

10 years ago
Depends on: 543295
Assignee

Updated

10 years ago
Depends on: 543296
Assignee

Comment 11

10 years ago
Av1, (context) un-bitrotted.

I'm submitting it to Try again, in hope something else fixed the issue in the meantime...
Attachment #420036 - Attachment is obsolete: true
Attachment #426452 - Flags: superreview?(bugzilla)
Attachment #420036 - Flags: superreview?(bugzilla)
Assignee

Comment 13

10 years ago
(In reply to comment #12)

This one proceeded much further:
{
http://build.mozillamessaging.com/buildbot/try/builders/Try%20server%20comm-central%20mac%20hg%20builder/builds/352

Undefined symbols:
  "nsAddbookUrl::nsAddbookUrl()", referenced from:
      nsAddbookUrlConstructor(nsISupports*, nsID const&, void**)in libmail.a(nsMailModule.o)
ld: symbol(s) not found
}

Am I out of luck?
stefanh, standard8, could you try it locally? Thanks.
Assignee

Comment 14

10 years ago
{
make[2]: MAKE@: Command not found
make[2]: *** [default] Error 127
}

http://hg.mozilla.org/comm-central/rev/b80103b363ea
(Bv1) configure.in: restore 'AC_PATH_PROGS(MAKE, ...' removed too soon by bug 485405.
Assignee

Updated

10 years ago
Blocks: 485405
Assignee

Updated

10 years ago
Whiteboard: [Remember to back out comment 14 after landing patch A]
(In reply to comment #14)

replied on Bug 485405. bustage fix worked, but there is no need for a block on that fix for this bug.
Assignee

Comment 16

10 years ago
(In reply to comment #15)

> replied on Bug 485405. bustage fix worked,

Well, I commented here because I didn't want to bother that bug more than required:
the port happened there, but I think c-c issues should be handled separately.

> but there is no need for a block on that fix for this bug.

In reply to your comment there:
I figured out |MAKE = @MAKE@| was involved, which lead me here, where that line will be removed;
I didn't want to mix/mess with bug fixing and tracking so a partial backout looked much easier and surer (to fix red asap).
I might have looked into this matter at review time, but now, unless the restored block causes an issue, I'm in favor of just letting it be until this very bug lands.
Assignee

Updated

10 years ago
Depends on: 547175
Assignee

Updated

10 years ago
Blocks: C192ConfSync
Serge, since Mark is certainly swamped can you do a quick double-check on this, that its both not bitrotted and would pass a try run still? (if its bitrotted please attach a new patch) Thanks
Comment on attachment 426452 [details] [diff] [review]
(Av1a) Just copy it
[Checkin: Comment 21]

I've just got around to trying this. There's one minor bit of bitrot, but that's about it.

A clobbered debug build worked fine on my machine.

Therefore I propose that we land this and keep an eye out for unexpected build failures - if we're getting them then we can assess if we need to backout and rework or otherwise.
Attachment #426452 - Flags: superreview?(bugzilla) → superreview+
serge, I'd love if you could land this; the fact that we have MAKE = @MAKE@ here prevents me from trying pymake on a c-c build (recurses using GNUMake)
Assignee

Comment 20

9 years ago
I'm sending it to Try first...
Assignee

Comment 21

9 years ago
Comment on attachment 426452 [details] [diff] [review]
(Av1a) Just copy it
[Checkin: Comment 21]


(In reply to comment #20)
> I'm sending it to Try first...

Now, passes for SM and TB :-)

http://hg.mozilla.org/comm-central/rev/895b22a261fe
Attachment #426452 - Attachment description: (Av1a) Just copy it → (Av1a) Just copy it [Checkin: Comment 21]
Assignee

Comment 22

9 years ago
(In reply to comment #14)
> http://hg.mozilla.org/comm-central/rev/b80103b363ea
> (Bv1) configure.in: restore 'AC_PATH_PROGS(MAKE, ...' removed too soon by bug
> 485405.

http://hg.mozilla.org/comm-central/rev/dc9bbe908fae
(Cv1) configure.in: remove now unneeded 'AC_PATH_PROGS(MAKE, ...'.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: helpwanted
Resolution: --- → FIXED
Whiteboard: [Remember to back out comment 14 after landing patch A]
Target Milestone: Thunderbird 3.1a1 → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.