485494 - the message count wrong on virtual folders when opening virtual folder in a new window

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Boying Lu]

Steps to re-produce:
1. Start TB
2. Create a virtual folder defined as "To or CC" to my e-mail address
3. Select the virtual folder
4. Right click on the folder and select "Open" in the popup menu
5. Send to an e-mail to your e-mail address from another machine or through 
   a web
6. Click "Get Mail" button to get new mails.

Expected result:
The Unread Message count should be increased by one

Actual result:
The count is increased by two.

Comment 1

[Boying Lu]

Attachment: Update the unread count only when the new message isn't in the cache

Comment 2

[David :Bienvenu]

what if I mark an existing message read/unread from an other window? Shouldn't that adjust the read count?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 369640 [details] [diff] [review]
Update the unread count only when the new message isn't in the cache

Passing to David - he knows this code better than I do.

Comment 4

[Boying Lu]

I'm making a new patch and will post it here when it's ready

Comment 5

[Boying Lu]

Attachment: the new patch also fixes the case when mark a message as "Read"/"Unread"

Comment 6

[David :Bienvenu]

this patch seems to handle getting two notifications for the same change by remembering the previous notification and ignoring it. Why are we getting two notifications? Are we registering twice? Seems like it would be better to fix the root cause.

Comment 7

[Boying Lu]

Attachment: Register the listener only once

Comment 8

[David :Bienvenu]

Comment on attachment 373288 [details] [diff] [review]
Register the listener only once

cool thx, that's much nicer. So the issue is that we're loading virtualFolders.dat twice, and adding multiple listeners. I'm wondering if we should just protect against this at the start of this function, and return early.

Comment 9

[David :Bienvenu]

Comment on attachment 373288 [details] [diff] [review]
Register the listener only once

thinking about it a bit more, that's what I'd like - a check for m_virtualFoldersLoaded at the start of this method. Thx for working on this!

Comment 10

[Boying Lu]

Attachment: check m_virtualFoldersLoaded at the start

Comment 11

[Ginn Chen]

FWIW: There is an extra space between return and NS_OK.

Comment 12

[Boying Lu]

Attachment: remove extra space

Comment 13

[David :Bienvenu]

Comment on attachment 373612 [details] [diff] [review]
remove extra space

looks good, thx for fixing this.

Comment 14

[Ginn Chen]

Pushed:
http://hg.mozilla.org/comm-central/rev/2fa9b1dc9030

Comment 15

[Mark Banner (:standard8)]

(In reply to comment #14)
> Pushed:
> http://hg.mozilla.org/comm-central/rev/2fa9b1dc9030

Please set the target milestone when marking fixed, it helps with tracking later on.