485734 - Make XForms build with Firefox 3.5

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Philipp Wagner [:imphil]]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.0.7) Gecko/2009022800 SUSE/3.0.7-1.1.6 Firefox/3.0.7
Build Identifier: 

There were some changes to the Mozilla codebase that requires changes to XForms in order to compile correctly.

Reproducible: Always

Comment 1

[Philipp Wagner [:imphil]]

Attachment: Fix the XForms build for FF 3.5

Comment 2

[Doron Rosenberg (IBM)]

Why can't we support seamonkey?

Comment 3

[Philipp Wagner [:imphil]]

I guess we could, but @SEAMONKEY_VERSION@ is gone and I didn't find a replacement right away. Should we hardcode it? Does anybody test XForms with Seamonkey? (or even use seamonkey?)

Comment 4

[aaronr]

I used Seamonkey almost exclusively until FF3 came out.  Seamonkey, AFAIK, hasn't made available a release based on that code base so I quit using it (except for monitoring newsgroups and IRC).  More info here: http://www.seamonkey-project.org/

Comment 5

[Doron Rosenberg (IBM)]

Comment on attachment 369843 [details] [diff] [review]
Fix the XForms build for FF 3.5

I use it, but if SEAMONKEY_VERSION is gone, fine with me.

Comment 6

[alexander :surkov (:asurkov)]

I would say it's preferable to hardcode seamonkey's version instead of removing seamonkey support completely. We could bump version each time when new stable seamoneky and xforms versions are available.

Comment 7

[Philipp Wagner [:imphil]]

Would it make sense to hardcode all versions (at least minVersion)? That requires that we remember to bump the version if we use a new feature of a particular version, but I guess that's easier to remember than looking through all relevant changes when writing the release notes.

Comment 8

[aaronr]

Just make sure that if you hard code Firefox version that it works with any checked out tree.  I'd rather not change it by hand every time I check out code to build.

Comment 9

[Philipp Wagner [:imphil]]

Attachment: toolkit is enough

I looked closer at the issue and we actually can remove the Firefox/Seamonkey/Mozilla parts entirely as the toolkit entry covers them all -- at least for the "get forms working" part. I don't know how much the XUL overlays for the config settings are different for Seamonkey/Firefox, but that would require different versions anyways, so no gain by using separate targetApplication entries.

While being at it I also incorporated the changes I already made at bug #340728 (was somehow forgotten). It mainly removes the install.js file (not used any more) and sets the BUILD_ID variable which is empty right now. Lastly it moves the version number out of Makefile.in into a version.txt file for easier changes.

Comment 10

[Philipp Wagner [:imphil]]

I meant bug #437491, no idea how the other one sneaked in here...

Comment 11

[alexander :surkov (:asurkov)]

Should this patch be landed on hg repository only?

Comment 12

[Philipp Wagner [:imphil]]

yes, hg only.

Comment 13

[alexander :surkov (:asurkov)]

Just to ensure, Philipp, does xforms with your patch work both on Firefox and Seamonkey, right?

Comment 14

[Philipp Wagner [:imphil]]

To quote https://developer.mozilla.org/en/Install_Manifests:
New in Firefox 3  Gecko 1.9 based applications allow you to use the special targetApplication id [e-mail] to say that the add-on is compatible with any toolkit app with a toolkit version matching the minVersion and maxVersion.

That's what I've seen in my testing, too.

Comment 15

[Philipp Wagner [:imphil]]

While at it, I forgot in the patch to delete the files
install.js
install.jst

and .cvsignore needs to be converted/renamed to .hgignore

Comment 16

[alexander :surkov (:asurkov)]

(In reply to comment #15)
> While at it, I forgot in the patch to delete the files
> install.js
> install.jst
> 
> and .cvsignore needs to be converted/renamed to .hgignore

Would be nice if you'll upload new patch then ;)

Comment 17

[Philipp Wagner [:imphil]]

*gg* ok, but this will not happen until I'm home tonight.

Comment 18

[alexander :surkov (:asurkov)]

checked in http://hg.mozilla.org/xforms/rev/e8d5ac23194c