485935 - Build the default language langpack (usually en-US) as part of `make package`

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

From bug 485860, we should build the English langpack as part of `make package`.

Comment 1

[Benjamin Smedberg]

Attachment: Package and upload the langpack by default, rev. 1

Comment 2

[Axel Hecht [:Pike]]

I'd prefer to not add an additional entry point to $(APP)/locales/Makefile.in, in particular if we're only calling it once.

Can't you just
$(MAKE) -C $(DEPTH)/browser/locales langpack_$(AB_CD) PKG_LANGPACK_PATH=
?

Comment 3

[Benjamin Smedberg]

You can if you want.

Comment 4

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/f968b19e1e2b

Comment 5

[(no longer active)]

Could we get this into 1.9.1 as well?

Comment 6

[Robert Kaiser]

Hmm, this is a core buildconfig bug report, but fixed with a Firefox-only patch... I filed bug 487283 to get this into the comm-central apps.

Comment 7

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/fcbd76b4ecf6 is a followup to this: UPLOAD_EXTRA_FILES shouldn't be prefixed with $(DIST)

Comment 8

[Benjamin Smedberg]

Comment on attachment 370012 [details] [diff] [review]
Package and upload the langpack by default, rev. 1

This is pretty much no-risk and gets us en-US language packs on branch, which is something localizers have requested.

Comment 9

[Robert Kaiser]

I'm confused. Why setting PKG_LANGPACK_PATH to empty and not leave that out and just use $(LANGPACK) for UPLOAD_EXTRA_FILES?

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 370012 [details] [diff] [review]
Package and upload the langpack by default, rev. 1

a191=beltzner

Comment 11

[Benjamin Smedberg]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fbff956b7fad and langpacks are coming forth

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

During the 3.5b4 release we generated en-US.xpi and uploaded it, but it was in the wrong location. Eg dist/en-US.xpi instead of dist/linux-i686/xpi/en-US.xpi, which leads to platforms overwriting each other on ftp.m.o

Poking around in the objdir for the linux build I get
 $ MOZ_PKG_PRETTYNAMES=1 make echo-variable-PKG_LANGPACK_PATH
 linux-i686/xpi/
as expected. The wrong path for releases seems to be a consequence of unsetting PKG_LANGPACK_PATH in browser/installer/Makefile.in (bug 485935). We need to revisit the solution here if you want en-US for releases too.

Comment 13

[Robert Kaiser]

It's actually a bug that we even generate language packs for every platform and don't upload them into one platform-neutral directory, as language packs are supposed to be cross-platform and AFAIK, we kept them this way successfully all the time.

Comment 14

[Benjamin Smedberg]

Comment #12-13 should be another bug if desired.

Comment 15

[(no longer active)]

Has this been done for 3.5.x release builds?  If so, where can one find the en-US langpacks?

Comment 16

[Armen [:armenzg]]

(In reply to comment #15)
> Has this been done for 3.5.x release builds?  If so, where can one find the
> en-US langpacks?
>
Here is one:
ftp://ftp.mozilla.org/pub/firefox/releases/3.5.6/en-US.xpi