Closed Bug 486036 Opened 11 years ago Closed 11 years ago

[PATCH] make install fails for Darwin/X11, but it should only die for OSX/Cocoa

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jeremyhu, Assigned: jeremyhu)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Build Identifier: xulrunner 1.9.0.7 OSX/darwin X11

~/src/macports-trunk/dports/devel/xulrunner $ cat files/make-install.patch 
--- toolkit/mozapps/installer/packager.mk.bak	2009-03-30 17:04:13.000000000 -0700
+++ toolkit/mozapps/installer/packager.mk	2009-03-30 17:05:06.000000000 -0700
@@ -410,7 +410,10 @@ make-package: stage-package
 # dist/sdk/lib -> prefix/lib/appname-devel-version/lib
 # prefix/lib/appname-devel-version/* symlinks to the above directories
 install:: stage-package
-ifneq (,$(filter WINNT Darwin,$(OS_ARCH)))
+ifneq (,$(filter WINNT,$(OS_ARCH)))
+	$(error "make install" is not supported on this platform. Use "make package" instead.)
+endif
+ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
 	$(error "make install" is not supported on this platform. Use "make package" instead.)
 endif
 	$(NSINSTALL) -D $(DESTDIR)$(installdir)


Reproducible: Always
I hope I'm doing the review process correctly.  Please tell me if setting "review" to "?" was not the correct thing to do.
Attachment #370262 - Flags: review?
Attachment #370262 - Flags: review? → review?(benjamin)
Depends on: 486782
No longer depends on: 486782
Depends on: 486782
Assignee: nobody → jeremyhu
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 370262 [details] [diff] [review]
Darwin/gtk fix for make install target

This should be conditioned on MOZILLA_FS_LAYOUT
Attachment #370262 - Flags: review?(benjamin) → review-
Attachment #370262 - Attachment is obsolete: true
Attachment #372573 - Flags: review?(benjamin)
Attachment #372573 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/cf62d5aef19e

Thanks Jeremy!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.