486076 - "make uploadsymbols" and MOZ_PKG_PRETTYNAMES=1 don't play nice on Mac

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In a test release run for 3.5b4:
 make uploadsymbols
  in dir /builds/moz2_slave/macosx_build/build/obj-firefox/ppc (timeout 1200 secs)
with
 MOZ_PKG_PRETTYNAMES=1
 MOZ_PKG_VERSION=3.5b4
yields
 /builds/moz2_slave/macosx_build/build/toolkit/crashreporter/tools/upload_symbols.sh ./dist/Firefox 3.5 Beta 4.crashreporter-symbols.zip
 Transferring symbols... ./dist/Firefox
 ./dist/Firefox: not a regular file
 make: *** [uploadsymbols] Error 1
So it's dying on the spaces in human friendly name for the release.

Earlier 'make buildsymbols' has yielded a dist/Firefox.zip via
  cd ./dist/crashreporter-symbols && \
          zip -r9D ../Firefox 3.5 Beta 4.crashreporter-symbols.zip .
	zip warning: name not matched: 3.5
	zip warning: name not matched: Beta
	zip warning: name not matched: 4.crashreporter-symbols.zip

Looks like
  http://mxr.mozilla.org/mozilla1.9.1/source/toolkit/mozapps/installer/package-name.mk#127
doesn't work so well for non-app files.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

This blows the run up before calling 'make package' so is moderately painful. Linux and Windows are OK - they produce firefox-3.5b4.crashreporter-symbols.zip

Comment 2

[(not currently active) Ted Mielczarek]

Fallout from bug 478221. Probably just need to add some quotes in the right places.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: add some quoting

I didn't test this on Mac, but I tested it on Windows using:
make buildsymbols uploadsymbols PKG_BASENAME="Firefox Awesome 3.x"

and it seemed to work just fine.

Comment 4

[(not currently active) Ted Mielczarek]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/78fb9a173674

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Works well in my release test run.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 370181 [details] [diff] [review]
add some quoting

Simple patch, fixes a regression we introduced that breaks "uploadsymbols" for release builds.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 370181 [details] [diff] [review]
add some quoting

a191=beltzner

Comment 8

[(not currently active) Ted Mielczarek]

Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2fc99e586460