48620 - Out of diskspace condition not handled correctly in FTP downloads

Status: VERIFIED DUPLICATE of bug 35161

(SeaMonkey :: UI Design, defect, P2)

Description

[Timm Murray]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m17) Gecko/20000807
BuildID:    2000080712

I wanted to save a file that was too big to save on a floppy (the URL above is
~3.0 MB). Instead of warning me that the file wouldn't fit on the disk, it just
downloaded as normal and attempted to save anyway

Reproducible: Didn't try

Comment 1

[Gervase Markham [:gerv]]

-> Networking? How do we handle out-of-disk-space or low-disk-space conditions?

Gerv

Comment 2

[Gervase Markham [:gerv]]

Smeg. Reassigning.

Gerv

Comment 3

[Blake Ross]

hmm..guess we should do this.

Comment 4

[Tom Everingham]

Checked the winNT build 2000082208.  If the user proceeds to download the file 
and he doesn't have enough disk space, he will see an 'unknown error 2 80004005' 
dialog and then crash.  Marking nsBeta3 for review.

Should this be a warning or should we prevent the save from happening?  

Comment 5

[Gagan]

->law

Comment 6

[verah (gone)]

Nav triage team: [nsbeta3+], adding crash keyword

Comment 7

[verah (gone)]

Nav triage team: P2

Comment 8

[Phil Peterson]

PDT agrees P2 due to the crash

Comment 9

[Diego]

see probable dupe of this: bug 50697 "Solaris/Linux crash when saving file if
over disk quota/out of disk space"

Comment 10

[Bill Law]

These patches will avoid a crash.  There's still work to do if we actually want 
to warn and handle the problem gracefully.

Index: nsStreamXferOp.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/xfer/src/nsStreamXferOp.cpp,v
retrieving revision 1.32
diff -w -r1.32 nsStreamXferOp.cpp
330a331
>                     break;
333a335
>                 break;

Index: base/src/nsBufferedStreams.cpp
> ===================================================================
> RCS file: /cvsroot/mozilla/netwerk/base/src/nsBufferedStreams.cpp,v
> retrieving revision 1.8
> diff -r1.8 nsBufferedStreams.cpp
> 335a336,339
> >     if (!mStream) {
> >         // Stream already cancelled/flushed; probably because of error.
> >         return NS_OK;
> >     }

Comment 11

[don]

Let's get both problems fixed in RTM, if poosible.

Comment 12

[Jason Eager]

Changing the summary to make it more descriptive, and adding relnote3 keyword.

Comment 13

[Phil Peterson]

PDT marking [rtm need info] since no code reviews are listed yet.

Comment 14

[Bill Law]

I've posted this attachment to bug 35161 to fix that bug and this one (and also
50697):

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=16135

Comment 15

[don]

Fix in hand.

Comment 16

[Bill Law]

Closing as dup of 35161.  I've fixed the crash and improved the message.

Still no advance warning if you're going to run out of space.  That will have to
wait for the next train.

This applies only in the "Save link as..." scenario, BTW.


*** This bug has been marked as a duplicate of 35161 ***

Comment 17

[Tom Everingham]

verified dup

Comment 18

[[e-mail]]

-> xpapps.

RELNOTE patrol...

Worth noting that this is duped to a bug that doesn't entirely sound the same, 
so does this need to be set to relnote and documented?