48623 - win installer needs user-friendly error handling

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[Henrik Gemal]

Somehow I just got a Error message when installing:
"Error ocurred during installation: -207 blablabla"
When pressing Ok in this error dialog the installer just quits.

The installer should show the user that the installation didn't success and 
he/she might try again.
Just quiting the installer is now very user friendly.

Comment 1

[Daniel Veditz [:dveditz]]

This is not the XPInstall engine but the install front end that does this. 
Changing component and reassigning. 

"Better error message when getting error" is a pretty vague summary when mixed 
in a list with general mozilla bugs so I'll change it to mention the installer. 
I'll also take the liberty of widening the scope, people have complained about 
the PR2 installer that if they get an error we delete all the .xpi files and 
they must download them all again. This really pisses people off.

I guess we shouldn't just leave junk on their disk taking up space so we should 
at least announce we're leaving it behind or better give users the choice of 
saving them.

This feels like a duplicate but I'll let Sean sort that out when he gets back.

Comment 2

[Daniel Veditz [:dveditz]]

Oops, forgot the reassign part...

Comment 3

[Henrik Gemal]

The installer should display some kind of message if the installation didn't 
success for some reason.
The text could be:
"The installation was interrupted or generated an error before Mozilla could be 
completly installed.
Your system has not been modified. To complete installation at another time, 
please run the installer again.
Press Close to close the installer."

Comment 4

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 5

[Henrik Gemal]

Just got the following error:
"Error occurred during installation - Navigator: -229 SCRIPT_ERROR"

Perhaps this could be changed to:
"An error occurred during installation! Mozilla Setup is unable to continue. 
Please try to run installer again or download a new version of the installer.
Error details:
Module: Navigator
Error text: SCRIPT_ERROR
Error number: 229

Comment 6

[Hixie (not reading bugmail)]

I just ran into this with a -214 DOES_NOT_EXIST error. Ugh.

Comment 7

[Matthew T (active 1999-2002)]

In general, wording of errors should be:
|
| <foo could not be done>, because <bar was wrong>. <suggestion for fixing the
| problem or avoiding it in future>.
|
E.g.: `Mozilla could not be installed, because the folder ?Program Files? could
not be changed. Check that the folder is not locked and that the disk is not
write-protected, and try again.' Extra text, such as `No changes have been made
to your installation disk', should be given in a separate paragraph below the
main error message.

So, the first step to fixing this bug is to make a three-column table: error
number, error fragment text (in en-US, this would be the bit after `because'),
and suggestions for fixing the error. Make provision in the error fragment text
for a relevant file or folder name to be inserted.

Comment 8

[Sean Su]

over to Curt.

Comment 9

[Syd Logan]

Resetting milestone of all nsbeta1-bugs, only nsbeta1+ bugs should have a target
milestone.

Comment 10

[Syd Logan]

Resetting milestone, only nsbeta1+ bugs can have a milestone on them, these are
niminated, but not yet plussed.

Comment 11

[Syd Logan]

only nsbeta1+ bugs can have milestones, resetting to ---

Comment 12

[Henrik Gemal]

*** Bug 108026 has been marked as a duplicate of this bug. ***

Comment 13

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer