Closed Bug 48642 Opened 25 years ago Closed 25 years ago

Spacebar should trigger XUL buttons

Categories

(SeaMonkey :: Themes, defect, P3)

Product:
SeaMonkey
Component:
Themes
Platform:
x86
Windows 98
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: hyatt)

References

Details

(Keywords: classic, platform-parity, polish)

If an XUL button has focus in win32, spacebar should trigger it. See also bug 44676 for how the button should respond visually (though it's more important that we at least get spacebar functioning, to be consistent with the OS and our web widgets)
Keywords: classic, polish, pp
oops, to ben
Assignee: hangas → ben
reassigning to me
Assignee: ben → BlakeR1234
Updating QA Contact to pmac@netscape.com
QA Contact: paw → pmac
hyatt, ben showed me some code awhile ago that seems like it was for this purpose. any idea why this doesn't work?
Status: NEW → ASSIGNED
cc jrgm for ideas
reassigning to hyatt for now.
Assignee: blakeross → hyatt
Status: ASSIGNED → NEW
Keywords: mozilla1.0
*** Bug 56495 has been marked as a duplicate of this bug. ***
*** Bug 60254 has been marked as a duplicate of this bug. ***
The reporting description says that when a XUL button has focus it should respond to space, but I never seen a XUL button having focus. This is the problem. buttons can't get focus. try tabbing to a button. Default button should also have focus by default. Is this really a themes thing? I guessed it to be a widget-thing as it should work regardless of theme.
Yes, it's a themes thing. Buttons don't take focus on the Mac, for example, so the Mac Classic theme doesn't allow buttons to be focusable.
Huh? win32 classic buttons take focus, do they not? And that's what I'm on.
Win32 buttons DO take focus. Even without the tabbing code in place, you should be able to test it by clicking and holding down a button. Then move the mouse away from the button and let go. The button now has focus, and in Win32, should respond to spacebar.
*** Bug 60848 has been marked as a duplicate of this bug. ***
Thanks Hyatt for fixing this! And to think it was only an s/keyCode/charCode problem this whole time...
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Summary: Spacebar should trigger XUL buttons in win32 classic → Spacebar should trigger XUL buttons
Marking verified on windows (2001-01-09-09-Mtrunk).
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.