Enable preferences to inhibit user whitelisting

RESOLVED FIXED in Thunderbird 3.0b3

Status

Thunderbird
Preferences
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

(Depends on: 1 bug)

Trunk
Thunderbird 3.0b3
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
As a followup to bug 452879, we need to decide whether to enable the suppression of junk whitelisting of the user's email and domain, and whether we need UI for it.

My initial inclination is to provide checkboxes for these two preferences in the UI (though I cringe at the wording of this chain of negatives).

As to defaults, I would suggest that we enable inhibitWhiteListingIdentityUser but not inhibitWhiteListingIdentityDomain. The matching user is much more common than the matching domain, and you would generally know of any important emails that you sent yourself. The domain matching is less common, and more likely to be someone that you would want to whitelist even at the risk of the occasional spam.
(Assignee)

Comment 1

9 years ago
Created attachment 372978 [details] [diff] [review]
Enable preference inhibitWhiteListingIdentityUser

I'm encouraging Bryan to add UI for this in bug 482617, which I will mark blocking of this bug. But the decision to enable the preference is unrelated to the UI, so let's just turn it on.

Dmose, you haven't been involved in this bug thread before, but I thought it would be fun to get you to do a review.
Attachment #372978 - Flags: superreview?(dmose)
Attachment #372978 - Flags: review?(dmose)
(Assignee)

Updated

9 years ago
Depends on: 482617
(Assignee)

Updated

9 years ago
Whiteboard: [needs r/sr dmose]

Updated

9 years ago
Attachment #372978 - Flags: ui-review?(clarkbw)
Attachment #372978 - Flags: superreview?(dmose)
Attachment #372978 - Flags: superreview+
Attachment #372978 - Flags: review?(dmose)
Attachment #372978 - Flags: review+
Comment on attachment 372978 [details] [diff] [review]
Enable preference inhibitWhiteListingIdentityUser

r+sr=dmose; since this is changing user-visible behavior, it needs ui-review as well, so I'm requesting that of Bryan.  Thanks for the patch!
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> r+sr=dmose; since this is changing user-visible behavior, it needs ui-review as
> well, so I'm requesting that of Bryan.  Thanks for the patch!

While you are free to request review of anyone that you want, I don't see how you can call it "UI review" when the patch has no UI, nor affects any UI. Yes it affects program behaviour, but by that logic so does fixing a crash.
Whiteboard: [needs r/sr dmose] → [needs ui-review clarkbw]
Comment on attachment 372978 [details] [diff] [review]
Enable preference inhibitWhiteListingIdentityUser

I think the term ui-review is a bit misleading.  Behaviour is the real UI, not the widgets that are drawn to the screen.  Generally the hardest "UI problems" are driven by poor behaviour and not by lack of good widgets.

Anyway, this sounds reasonable to me and lets deal with the possible widgets in bug 482617
Attachment #372978 - Flags: ui-review?(clarkbw) → ui-review+
Yeah, that flag should probably be named ue-review, since it's about reviewing changes to the user experience, not necessarily to the interface per se.
Keywords: checkin-needed
Whiteboard: [needs ui-review clarkbw]
Checked in: http://hg.mozilla.org/comm-central/rev/3642a14d6f7c
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

8 years ago
Depends on: 531773
You need to log in before you can comment on or make changes to this bug.