486536 - need a way to set the titlebar text color on Mac

Status: ASSIGNED

(Core :: Widget: Cocoa, enhancement, P5)

Description

[Mike Connor [:mconnor]]

This would be really really useful for Personas, since right now we're limited to setting titlebar colors that work with black as a text color.

See http://blog.seanmartell.com/wp-content/uploads/2009/02/6.jpg for example of what we'd like to support.

Comment 1

[Markus Stange [:mstange]]

Do you need the ability to set a custom color, e.g. using attributes like "(in)activetitlebartextcolor", or would it be enough if the window looks at the titlebar background color and chooses either black or white as text color, depending on the background's brightness?

Comment 2

[Markus Stange [:mstange]]

This build implements the lightweight way I suggested:
https://build.mozilla.org/tryserver-builds/2009-05-13_06:[e-mail]-try-38434b624f3/[e-mail]

I.e. it doesn't add any API; it just switches to white text if the background is dark.

Mike, Myk, is that sufficient for your purposes?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

> Mike, Myk, is that sufficient for your purposes?

Hey Markus, sorry for not responding sooner.  Switching to white text is a definite improvement, although ideally we'd love to have the capability to specify the text color as well, just as we can currently specify the background color with (in)activetitlebarcolor, so that Personas designers can match a specific background color with a specific text color, just as they do in the browser chrome.

Comment 4

[Kim]

Cool, this feature is really important for theme designers that want to use the unified toolbar feature.
See here:
http://forums.mozillazine.org/viewtopic.php?f=18&t=1308935&p=6747465#p6747465

please add this feature!

Comment 5

[Tony Chung [:tchung]]

so is bug 530103 a dupe of this one?

Comment 6

[Myk Melez [:myk] [@mykmelez]]

I think they're complementary.  This bug is about adding the feature to the platform, while bug 530103 is about using the feature in lightweight themes.

Comment 7

[Kevin]

What is the status on this bug?  Is there any way to experiment with this setting in the current Minefield release?

Comment 8

[Markus Stange [:mstange]]

Attachment: wip

This is the wip patch that I built the tryserver build with. It needs to be updated to trunk and logic for specifying the color with an attribute needs to be added.
I might find time for this next week.

Comment 9

[Mike Kaply [:mkaply]]

this seems to have fallen off the radar. With Firefox 4, dark personas on Mac are unreadable. Any chance of progress?