530103 - Personas that set dark background-color cause unreadable titlebar text under OSX

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[nemo]

See the screenshot.  Title bar has black text on black background with a slight text shadow to make the letters barely readable.

What would be nice to see is if the background-image could extend up into the titlebar, only perhaps with colour set very light - something like a 20% opacity against white, so you still see the image, but the titlebar text shows up clearly.

I do something like this with my Gnome bar so that text shows up well on a semi-opaque titlebar, but the image continues uninterrupted.

(note, filing this in wrong area due to bug #528867 will try moving it to Firefox General immediately)

Comment 1

[Tony Chung [:tchung]]

dao, blair;  not sure if there's any thing mozilla can do here, but it is an annoying problem with a dark theme is overlaying on the black title bar text.  Its ridiculously hard to read.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

1) This is a dupe of some bug I think Markus is working on (or has already fixed); I can't find it now :/
2) Widget:Mac is dead unless you're a XUL app on Gecko 1.8.1; long live Widget:Cocoa!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> 1) This is a dupe of some bug I think Markus is working on (or has already
> fixed); I can't find it now :/

That one was when leaving fullscreen mode. It's bug 521744.

Comment 4

[Markus Stange [:mstange]]

Making the background-image extend into the titlebar is bug 513158 and bug 520637, setting titlebar text color is bug 486536.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Anything we can do for Firefox 4?

Comment 8

[Joe Drew (not getting mail)]

I don't think I'd block on making this better.

Is it true that the best option is to allow persona authors to specify another colour? Or should we maybe set the OS X titlebar text to the "highlight" colour persona authors already use?

Comment 9

[Caspy7]

I've been having some light sensitivity issues so I've been using a dark persona.  This issue is very apparent with it.

Thought I'd refresh things for more saliency.
Potential solutions I can see:
- Let persona authors specify - this could be optional. No need to break compatibility. Could also be viewed as a feature (think pink for a Hello Kitty persona).
- Use the highlight color previously specified by authors (see above comment).  No clue on this one, don't know how this works, but would ask: Would said color necessarily solve the problem presented in this bug? 
- Don't know if this is sanely possible, but I had the idea to take an average of the top 20 pixels or so of the panorama image and then choose white or black text based on that.
- Not sure if it would be desirable, but a translucent background could be added to the top bar.

Just trying to reignite the issue with some ideas...

Comment 10

[Nicky McCurdy]

"Or should we maybe set the OS X titlebar text to the "highlight" colour
persona authors already use?"
This would be great, or having a more evident white shadow or stroke on the title bar. And I also like the idea of maybe having a transparent white or light gray background just for the title text, configurable by persona maker possibly.

Comment 12

[Patrick Walton (:pcwalton)]

I believe this happened to be fixed by removing the title bar text on Mac OS X.