487155 - [IE 7/ IE 8]:Formatting looks broken in Forum thread

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: CSS of a forum thread

browser:IE8

steps to reproduce:
1.Go to SUMO home page.
2.Navigate to Firefox Support /Forums /Firefox /firefox crashes every time i open facebook 

observed behavior:
Formatting/CSS looks broken in this page(see screenshot)

Comment 1

[Paul Craciunoiu [:paulc]]

Ah, the perks of IE, always changing... :)

Comment 2

[Chris Ilias [:cilias]]

Is this an IE7 issue as well? See <https://support.mozilla.com/tiki-view_forum_thread.php?locale=en-US&comments_parentId=352811&forumId=3>. Or is that a separate bug?

Comment 3

[Chris Ilias [:cilias]]

You know what? I forgot the IE8 already shipped. :-) So the screenshot in the contributors forum is probably of IE8.

Comment 4

[Tanner Filip [:tanner]]

Hi, this bug also applies in IE 7

Comment 5

[Paul Craciunoiu [:paulc]]

Checked, this still happens.

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: fix most issues for IE6, 7 and 8

This should fix most issues in all 3 popular versions of IE. For IE6, copy over the image attached.

Comment 8

[Paul Craciunoiu [:paulc]]

Attachment: searchmodule.gif for IE6

Comment 9

[James Socol [:jsocol, :james]]

Comment on attachment 417597 [details] [diff] [review]
fix most issues for IE6, 7 and 8

Lots of deleteions, I like! But the text in the search module is clipped at the baseline in IE7 and IE8. It's fine except for the descender on the 'p,' which gets cut off.

The issue is not caused by the patch, but I'd rather fix it. Let me know if you need help with that, it's a little weird.

Comment 10

[James Socol [:jsocol, :james]]

Attachment: screenshot of clipping

Here's the text clipping.

Comment 11

[Paul Craciunoiu [:paulc]]

Attachment: v2, fixes a few more things

This fixes the text clipping and also positions the #commentshelp div better on IE6 (mozcommon/ie.css)

Comment 12

[James Socol [:jsocol, :james]]

Comment on attachment 418205 [details] [diff] [review]
v2, fixes a few more things

Very nice! Looks good in IE6/7/8. Glad to finally get this bug fixed.

Comment 13

[Paul Craciunoiu [:paulc]]

r58142
This patch fails on Fennec (only for one file). I would prefer to see a merge with trunk happening, rather than trying to solve the conflicts. What do you think, James?

Comment 14

[James Socol [:jsocol, :james]]

The mobile themes will need to be pretty much separate from the desktop themes. I'd rather get this applied to the Fennec branch now.

Comment 15

[Paul Craciunoiu [:paulc]]

On it.

Comment 16

[Paul Craciunoiu [:paulc]]

r58147, completely forgot to add the gif to trunk.

I'll file a patch for fennec in just a bit.

Comment 17

[Paul Craciunoiu [:paulc]]

Attachment: fennec v1

Some things weren't necessary (issue-status is still a <select> on forums), while new things are added (the textarea was too wide on IE7/8).

Comment 18

[James Socol [:jsocol, :james]]

Comment on attachment 418275 [details] [diff] [review]
fennec v1

WFM. Thanks.

Comment 19

[Paul Craciunoiu [:paulc]]

r58200 for fennec.

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: IE 7 on mobile.SUMO

Look at the "browse all articles..." link.

Comment 21

[Paul Craciunoiu [:paulc]]

Attachment: fennec fix "browse all" link

Good find Stephen. The link actually doesn't look right for me even on Fx3.5.

This patch should do it. I wrapped the link in a div of class "browseall", like this:
{DIV(class=browseall)}''((Article list|Browse all support articles...))''{DIV}
Instead of just:
''((Article list|Browse all support articles...))''
Thanks to Chris for reminding me the syntax :)

Comment 22

[James Socol [:jsocol, :james]]

Comment on attachment 420778 [details] [diff] [review]
fennec fix "browse all" link

The text now seems to float in the middle of the two columns of articles. This is in both Fx3.6 and IE7.

Comment 23

[James Socol [:jsocol, :james]]

Attachment: fx3.6 on Win7

This is from Firefox, but the result is roughly the same on IE7 (the text is ~5 pixels lower).

Comment 24

[Paul Craciunoiu [:paulc]]

(In reply to comment #23)
> Created an attachment (id=420791) [details]
> fx3.6 on Win7
That seems odd. I don't get nearly that much whitespace between the two columns -- how did you?

Comment 25

[James Socol [:jsocol, :james]]

Comment on attachment 420778 [details] [diff] [review]
fennec fix "browse all" link

OK, I'd forgotten to reassign the new mobile start page to mozms after reimporting a regular SUMO dump and creating the mobile start... yadda yadda yadda. It works. My bad.

Comment 26

[Paul Craciunoiu [:paulc]]

r59392 (fennec)

Note: when doing this on production, we must ensure to add the class "browseall" to the link in cause (see attachment 420038 [details]). Comment 21 shows the syntax.

Comment 27

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on:

* https://support-stage.mozilla.org
* http://support-stage.mozilla.org/search.php?locale=en-US&q=mobile&sa=
* https://mobile.support-stage.mozilla.org/en-US/kb/

Using:

* IE 6, 7, 8
* Opera 10.10
* Safari 4.0.4
* Google Chrome 3.0.195.38
* Firefox 3.5
* Firefox 3.6 rc2

Comment 28

[Stephen Donner [:stephend] Not actively reading bugmail]

...and https://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&forumId=1&comments_parentId=309823, of course.  Sigh; long day.

Comment 29

[James Socol [:jsocol, :james]]

Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.

Comment 30

[James Socol [:jsocol, :james]]

On branch, r62421.

Comment 31

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.